8000 fix(@angular/cli): properly handle Node.js `require()` errors with ESM modules by alan-agius4 · Pull Request #30288 · angular/angular-cli · GitHub
[go: up one dir, main page]
Skip to content

fix(@angular/cli): properly handle Node.js require() errors with ESM modules #30288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

fix(@angular/cli): properly handle Node.js require() errors with ESM modules #30288

8000 merged 1 commit into from
May 12, 2025

Conversation

alan-agius4
Copy link
Collaborator

Resolve ERR_REQUIRE_ASYNC_MODULE when attempting to require() ESM modules in a CommonJS context.

Closes #30286

@alan-agius4
fix(@angular/cli): properly handle Node.js require() errors with ES…
bb2137b 
…M modules

Resolve `ERR_REQUIRE_ASYNC_MODULE` when attempting to `require()` ESM modules in a CommonJS context.

Closes angular#30286
@alan-agius4 alan-agius4 requested a review from clydin May 12, 2025 09:17
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 12, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 12, 2025
@clydin clydin merged commit 0ae9c1f into angular:main May 12, 2025
34 checks passed
@clydin
Copy link
Member
clydin commented May 12, 2025

The changes were merged into the following branches: main, 19.2.x, 20.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/cli target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESM builder with top-level await fails to load on node ≥ 20.19.0
2 participants
@alan-agius4 @clydin
0