-
Notifications
You must be signed in to change notification settings - Fork 12k
feature(completion): ng completion
made more robust
#2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(completion): ng completion
made more robust
#2286
Conversation
…ript now works for OPAM in zsh.
ng completion
made more robustng completion
made more robust
…s something other than builtin commands.
@@ -73,6 +73,9 @@ elif type compctl &>/dev/null; then | |||
} | |||
|
|||
compctl -K _ng_completion ng | |||
else | |||
echo "Sorry mate, can't find working builtin shell command complete / compctl.'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can you remove the mate
bit and just leave Sorry,
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworded the error.
LGTM aside from the nit. |
By the way, this takes care of issue #2284. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Made the shell detection depending on
type
builtin function. The script now works for OPAM in zsh. This PR fixes #2284.