feature(completion): ng completion made more robust
#2286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript now works for OPAM in zsh.
ng completion made more robustng completion made more robust
…s something other than builtin commands.
filipesilva
suggested changes
Oct 3, 2016
| @@ -73,6 +73,9 @@ elif type compctl &>/dev/null; then | |||
| } | |||
|
|
|||
| compctl -K _ng_completion ng | |||
| else | |||
| echo "Sorry mate, can't find working builtin shell command complete / compctl.'" | |||
There was a problem hiding this comment.
Nit: can you remove the mate bit and just leave Sorry,?
|
LGTM aside from the nit. |
filipesilva
approved these changes
Oct 9, 2016
|
By the way, this takes care of issue #2284. |
JJayet
pushed a commit
to JJayet/angular-cli
that referenced
this pull request
Oct 14, 2016
Brocco
pushed a commit
that referenced
this pull request
Oct 19, 2016
texel
pushed a commit
to splice/angular-cli
that referenced
this pull request
Nov 3, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the shell detection depending on
typebuiltin function. The script now works for OPAM in zsh. This PR fixes #2284.