8000 feature(completion): `ng completion` made more robust by catull · Pull Request #2286 · angular/angular-cli · GitHub
[go: up one dir, main page]

Skip to content

feature(completion): ng completion made more robust #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

catull
Copy link
Contributor
@catull catull commented Sep 21, 2016

Made the shell detection depending on type builtin function. The script now works for OPAM in zsh. This PR fixes #2284.

@catull catull changed the title ng completion made more robust feature(completion): ng completion made more robust Sep 27, 2016
@@ -73,6 +73,9 @@ elif type compctl &>/dev/null; then
}

compctl -K _ng_completion ng
else
echo "Sorry mate, can't find working builtin shell command complete / compctl.'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you remove the mate bit and just leave Sorry,?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded the error.

@filipesilva
Copy link
Contributor

LGTM aside from the nit.

@filipesilva filipesilva self-assigned this Oct 3, 2016
@catull
Copy link
Contributor Author
catull commented Oct 9, 2016

By the way, this takes care of issue #2284.

@catull catull deleted the issue-2284-ng-completion-more-robust branch October 10, 2016 22:56
JJayet pushed a commit to JJayet/angular-cli that referenced this pull request Oct 14, 2016
Brocco pushed a commit that referenced this pull request Oct 19, 2016
texel pushed a commit to splice/angular-cli that referenced this pull request Nov 3, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng complete not working for zsh if you have OPAM (OCaml package manager) installed
3 participants
0