8000 fix(compiler-cli): handle initializer APIs wrapped in type casts by crisbeto · Pull Request #62203 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

fix(compiler-cli): handle initializer APIs wrapped in type casts #62203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): handle initializer APIs wrapped in type casts #62203

wants to merge 1 commit into from
+38 −0

Conversation

crisbeto
Copy link
Member

Fixes that the logic recognizing initializer APIs didn't account for the expression being wrapped in an as expresion or in a parenthesized expression. This was already accounted for in the diagnostic so these changes align the behavior between them.

Fixes #62197.

@crisbeto
fix(compiler-cli): handle initializer APIs wrapped in type casts
c8b75c1 
Fixes that the logic recognizing initializer APIs didn't account for the expression being wrapped in an `as` expresion or in a parenthesized expression. This was already accounted for in the diagnostic so these changes align the behavior between them.

Fixes angular#62197.
@crisbeto crisbeto requested a review from devversion June 23, 2025 07:13
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 23, 2025
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Jun 23, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 23, 2025
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 23, 2025
@crisbeto
Copy link
Member Author

This PR was merged into the repository by commit d25a6a0.

The changes were merged into the following branches: main, 20.0.x

@crisbeto crisbeto closed this in d25a6a0 Jun 23, 2025
crisbeto added a commit that referenced this pull request Jun 23, 2025
@crisbeto
fix(compiler-cli): handle initializer APIs wrapped in type casts (#62203
3eb5a79 
)

Fixes that the logic recognizing initializer APIs didn't account for the expression being wrapped in an `as` expresion or in a parenthesized expression. This was already accounted for in the diagnostic so these changes align the behavior between them.

Fixes #62197.

PR Close #62203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

viewChild query is never resolved if using explicit type casting
2 participants
@crisbeto @devversion
0