8000 Migrate `packages/compiler` and `packages/elements` by devversion · Pull Request #61566 · angular/angular · GitHub
[go: up one dir, main page]

Skip to content

Migrate packages/compiler and packages/elements #61566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: migrate packages/compiler to ts_project
Migrates `packages/compiler` to `ts_project`.
  • Loading branch information
devversion committed May 27, 2025
commit e88fd08825b65d05fd2b969f8dea7bdcfef53dfa
9 changes: 6 additions & 3 deletions packages/compiler/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
load("//tools:defaults.bzl", "ng_package", "ts_library", "tsec_test")
load("//tools:defaults2.bzl", "npm_package")
load("//tools:defaults.bzl", "ng_package", "tsec_test")
load("//tools:defaults2.bzl", "npm_package", "ts_project")

package(default_visibility = ["//visibility:public"])

ts_library(
ts_project(
name = "compiler",
srcs = glob(
[
Expand Down Expand Up @@ -37,7 +37,10 @@ ng_package(
"//integration:__subpackages__",
"//modules/ssr-benchmarks:__subpackages__",
"//packages/compiler-cli/integrationtest:__pkg__",
"//packages/core/test/bundling:__subpackages__",
"//packages/core/test/playground/zone-signal-input:__pkg__",
"//packages/language-service/test:__pkg__",
"@npm//@angular/build-tooling/shared-scripts:__subpackages__",
],
deps = [
":compiler",
Expand Down
20 changes: 12 additions & 8 deletions packages/compiler/test/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite")
load("//tools:defaults2.bzl", "ts_project&quo 8000 t;)

# Test that should only be run in node
NODE_ONLY = [
"**/*_node_only_spec.ts",
"aot/**/*.ts",
]

ts_library(
ts_project(
name = "test_lib",
testonly = True,
srcs = glob(
["**/*.ts"],
exclude = NODE_ONLY,
),
deps = [
"//packages:types",
interop_deps = [
"//packages/common",
"//packages/compiler",
"//packages/compiler/test/expression_parser/utils",
Expand All @@ -26,22 +26,26 @@ ts_library(
"//packages/platform-browser-dynamic",
"//packages/platform-browser/testing",
"//packages/private/testing",
"@npm//source-map",
],
deps = [
"//:node_modules/source-map",
],
)

ts_library(
ts_project(
name = "test_node_only_lib",
testonly = True,
srcs = glob(
NODE_ONLY,
),
deps = [
interop_deps = [
":test_lib",
"//packages/compiler",
"//packages/compiler/test/expression_parser/utils",
"//packages/core",
"@npm//typescript",
],
deps = [
"//:node_modules/typescript",
],
)

Expand Down
7 changes: 4 additions & 3 deletions packages/compiler/test/expression_parser/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite")
load("//tools:defaults2.bzl", "ts_project")

ts_library(
ts_project(
name = "expression_parser_lib",
testonly = True,
srcs = glob(["**/*.ts"]),
deps = [
interop_deps = [
"//packages/compiler",
"//packages/compiler/test/expression_parser/utils",
"//packages/platform-browser/testing",
Expand Down
10 changes: 5 additions & 5 deletions packages/compiler/test/expression_parser/utils/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
load("//tools:defaults.bzl", "ts_library")
load("//tools:defaults2.bzl", "ts_project")

ts_library(
ts_project(
name = "utils",
testonly = True,
srcs = glob(
["*.ts"],
),
interop_deps = [
"//packages/compiler",
],
visibility = [
"//packages/compiler/test:__subpackages__",
],
deps = [
"//packages/compiler",
],
)
2 changes: 1 addition & 1 deletion packages/compiler/test/i18n/integration_common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {HtmlParser} from '../../src/ml_parser/html_parser';
import {ResourceLoader} from '../../src/resource_loader';
import {Component, DebugElement, TRANSLATIONS, TRANSLATIONS_FORMAT} from '@angular/core';
import {ComponentFixture, TestBed} from '@angular/core/testing';
import {By} from '@angular/platform-browser/src/dom/debug/by';
import {By} from '@angular/platform-browser';
import {stringifyElement} from '@angular/private/testing';
import {expect} from '@angular/private/testing/matchers';

Expand Down
2 changes: 1 addition & 1 deletion packages/compiler/test/integration_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import {Component, Directive, Input} from '@angular/core';
import {ComponentFixture, TestBed, waitForAsync} from '@angular/core/testing';
import {By} from '@angular/platform-browser/src/dom/debug/by';
import {By} from '@angular/platform-browser';
import {expect} from '@angular/private/testing/matchers';

describe('integration tests', () => {
Expand Down
7 changes: 4 additions & 3 deletions packages/compiler/test/ml_parser/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite")
load("//tools:defaults2.bzl", "ts_project")

ts_library(
ts_project(
name = "ml_parser_lib",
testonly = True,
srcs = glob(["**/*.ts"]),
deps = [
interop_deps = [
"//packages:types",
"//packages/compiler",
"//packages/compiler/test/ml_parser/util",
Expand Down
8 changes: 4 additions & 4 deletions packages/compiler/test/ml_parser/util/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
load("//tools:defaults.bzl", "ts_library")
load("//tools:defaults2.bzl", "ts_project")

ts_library(
ts_project(
name = "util",
testonly = True,
srcs = glob(["**/*.ts"]),
visibility = ["//visibility:public"],
deps = [
interop_deps = [
"//packages:types",
"//packages/compiler",
],
visibility = ["//visibility:public"],
)
7 changes: 4 additions & 3 deletions packages/compiler/test/render3/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
load("//tools:defaults.bzl", "jasmine_node_test")
load("//tools:defaults2.bzl", "ts_project")

ts_library(
ts_project(
name = "test_lib",
testonly = True,
srcs = glob(
["**/*.ts"],
),
deps = [
interop_deps = [
"//packages:types",
"//packages/compiler",
"//packages/compiler/test/expression_parser/utils",
Expand Down
8 changes: 4 additions & 4 deletions packages/compiler/test/selector/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite")
load("//tools:defaults2.bzl", "ts_project")

ts_library(
ts_project(
name = "selector_lib",
testonly = True,
srcs = glob(["**/*.ts"]),
deps = [
"//packages:types",
interop_deps = [
"//packages/compiler",
"//packages/platform-browser/testing",
"//packages/private/testing",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ index d6249b8..707ae39 100755
config_file = ":%s_config_file" % name,
deps = [
- "@npm//@angular/compiler-cli",
+ "@angular//packages/compiler",
+ "@angular//packages/compiler:npm_package",
+ "@angular//packages/compiler-cli:npm_package",
"@npm//@angular/build-tooling/shared-scripts/angular-optimization:js_lib",
],
Expand Down Expand Up @@ -151,7 +151,7 @@ index b2729ad..80ab926 100755
deps = [
"@npm//@angular/build",
- "@npm//@angular/compiler-cli",
+ "@angular//packages/compiler",
+ "@angular//packages/compiler:npm_package",
+ "@angular//packages/compiler-cli:npm_package",
"@npm//@babel/core",
"@npm//@babel/plugin-proposal-async-generator-functions",
Expand Down
0