10000 feat(devtools): add getSignalGraph api to devtools protocol by milomg · Pull Request #61548 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

feat(devtools): add getSignalGraph api to devtools protocol #61548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(devtools): add getSignalGraph api to devtools protocol #61548

wants to merge 1 commit into from

Conversation

milomg
Copy link
Contributor
@milomg milomg commented May 21, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This allows the devtools frontend code to query the framework getSignalGraph API, which will enable us to visualize the signals graph in devtools

Related: #60772 (currently we'll get an error if we call getSignalGraph on a componentless injector)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information
8000

@pullapprove pullapprove bot requested review from devversion and mmalerba May 21, 2025 01:10
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: devtools labels May 21, 2025
@ngbot ngbot bot added this to the Backlog milestone May 21, 2025
@devversion devversion requested review from alxhub and removed request for devversion May 21, 2025 13:27
@pullapprove pullapprove bot requested a review from devversion May 21, 2025 13:27
@devversion devversion requested review from AleksanderBodurri and removed request for devversion May 21, 2025 15:42
@JeanMeche JeanMeche removed request for mmalerba and alxhub June 1, 2025 15:03
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 1, 2025
@milomg
feat(devtools): add getSignalGraph api to devtools protocol
20f816b 
add a new devtools backend api getSignalGraph that emits a
latestSignalGraph to the devtools frontend
@angular-robot angular-robot bot requested a review from JeanMeche June 3, 2025 05:34
@kirjs
Copy link
Contributor
kirjs commented Jun 3, 2025

@milomg Can you please rebase this PR agains the patch branch?

@kirjs kirjs added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jun 3, 2025
@JeanMeche JeanMeche added target: minor This PR is targeted for the next minor release action: merge The PR is ready for merge by the caretaker and removed target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 3, 2025
@JeanMeche JeanMeche removed their request for review June 3, 2025 12:30
@milomg
Copy link
Contributor Author
milomg commented Jun 3, 2025

@kirjs I'm assuming that now the PR is targeting minor that being on top of main is ok? If not, I'm happy to rebase

@kirjs
Copy link
Contributor
kirjs commented Jun 3, 2025

This PR was merged into the repository by commit 4fa1dca.

The changes were merged into the following branches: main

@kirjs kirjs closed this in 4fa1dca Jun 3, 2025
@milomg milomg deleted the signal-graph-4 branch June 6, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@AleksanderBodurri AleksanderBodurri AleksanderBodurri approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: devtools detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@milomg @kirjs @JeanMeche @AleksanderBodurri
0