8000 build: remove `@types/diff` by alan-agius4 · Pull Request #61447 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

build: remove @types/diff #61447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

build: remove @types/diff #61447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
# Input hashes for repository rule npm_translate_lock(name = "npm2", pnpm_lock = "@//:pnpm-lock.yaml").
# This file should be checked into version control along with the pnpm-lock.yaml file.
.npmrc=-1406867100
package.json=-793320858
package.json=-115596762
packages/compiler-cli/package.json=571832290
packages/compiler/package.json=-426903429
pnpm-lock.yaml=252365364
pnpm-lock.yaml=1434682987
pnpm-workspace.yaml=353334404
tools/bazel/rules_angular_store/package.json=-239561259
yarn.lock=2135122510
yarn.lock=1406221091
1 change: 0 additions & 1 deletion adev/shared-docs/pipeline/guides/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ ts_project(
],
deps = [
"//:node_modules/@bazel/runfiles",
"//:node_modules/@types/diff",
"//:node_modules/@types/jsdom",
"//:node_modules/@types/node",
"//:node_modules/diff",
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@
"@types/bluebird": "^3.5.27",
"@types/chrome": "^0.0.322",
"@types/convert-source-map": "^2.0.0",
"@types/diff": "^7.0.0",
"@types/dom-navigation": "^1.0.5",
"@types/hammerjs": "2.0.46",
"@types/jasmine": "^5.0.0",
Expand Down
4 changes: 1 addition & 3 deletions packages/bazel/test/ng_package/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ ts_library(
deps = [
"//packages:types",
"@npm//@bazel/runfiles",
"@npm//@types/diff",
"@npm//diff",
],
)

Expand All @@ -85,7 +85,6 @@ jasmine_node_test(
# file is based on non-ivy output and therefore won't work for ngc and Ivy at the same time.
# TODO: Update test to rely on Ivy partial compilation after View Engine's removal, update the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related, but since I saw it, might as well say something. VE was removed already, right?

# golden files as appropriate for the change in compilation.
deps = ["@npm//diff"],
)

nodejs_binary(
Expand All @@ -97,7 +96,6 @@ nodejs_binary(
":example_spec_lib",
"//packages/bazel/test/ng_package/example:npm_package",
"//packages/bazel/test/ng_package/example-with-ts-library:npm_package",
"@npm//diff",
],
entry_point = ":example_package.spec.ts",
templated_args = ["--accept"],
Expand Down
1 change: 0 additions & 1 deletion packages/core/schematics/utils/tsurge/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ ts_project(
],
visibility = [":users"],
deps = [
"//:node_modules/@types/diff",
"//:node_modules/@types/jasmine",
"//:node_modules/chalk",
"//:node_modules/diff",
Expand Down
7 changes: 0 additions & 7 deletions pnpm-lock.yaml
View file
Open in de C83C sktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,6 @@

"@angular/ng-dev@https://github.com/angular/dev-infra-private-ng-dev-builds.git#8f3889eedc8b9f55b266f129b9ada4ef1a453fe1":
version "0.0.0-aef915fe9306251b2dc4edd3717ccb5d4fb5c75c"
uid "8f3889eedc8b9f55b266f129b9ada4ef1a453fe1"
resolved "https://github.com/angular/dev-infra-private-ng-dev-builds.git#8f3889eedc8b9f55b266f129b9ada4ef1a453fe1"
dependencies:
"@google-cloud/spanner" "7.21.0"
Expand Down Expand Up @@ -4149,11 +4148,6 @@
"@types/d3-transition" "*"
"@types/d3-zoom" "*"

"@types/diff@^7.0.0":
version "7.0.2"
resolved "https://registry.yarnpkg.com/@types/diff/-/diff-7.0.2.tgz#d638edebf3c97aa4962b6f1164a7921ab3de9f83"
integrity sha512-JSWRMozjFKsGlEjiiKajUjIJVKuKdE3oVy2DNtK+fUo8q82nhFZ2CPQwicAIkXrofahDXrWJ7mjelvZphMS98Q==

"@types/dom-navigation@^1.0.5":
version "1.0.5"
resolved "https://registry.yarnpkg.com/@types/dom-navigation/-/dom-navigation-1.0.5.tgz#5fd6ed014d3ee66b53b0733b6c50994c105b542d"
Expand Down
0