refactor(zone.js): additional cleanups to reduce code size #61444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f0a892 to
76787a6
Compare
NOTE: Some code paths containing special handling for IE have been removed because we no longer support IE. In this commit, we perform separate cleanups inside the zone.js package to reduce the number of `&&` operations by using optional chaining, as it makes the code smaller and more readable. The `copySymbolProperties` function is now tree-shakable in browser bundles because its implementation is only set in Node.js.
76787a6 to
c5f01b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot
2BB8
be applied right now. Please check back later.
NOTE: Some code paths containing special handling for IE have been removed because we no longer support IE.
In this commit, we perform separate cleanups inside the zone.js package to reduce the number of
&&operations by using optional chaining, as it makes the code smaller and more readable.The
copySymbolPropertiesfunction is now tree-shakable in browser bundles because its implementation is only set in Node.js.