8000 standard schema support by mmalerba · Pull Request #61438 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

standard schema support #61438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 1, 2025
Merged

standard schema support #61438

merged 5 commits into from
Jul 1, 2025

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba requested review from kirjs and alxhub May 16, 2025 20:59
@mmalerba mmalerba added target: feature This PR is targeted for a feature branch (outside of main and semver branches) area: forms labels May 20, 2025
@ngbot ngbot bot added this to the Backlog milestone May 20, 2025
@mmalerba mmalerba marked this pull request as ready for review June 17, 2025 00:35
@mmalerba mmalerba changed the title wip: standard schema support standard schema support Jun 17, 2025
@mmalerba mmalerba moved this to In Progress in Experimental Signal Forms Jun 25, 2025
@mmalerba mmalerba self-assigned this Jun 25, 2025
@mmalerba mmalerba requested a review from leonsenft June 27, 2025 02:42
leonsenft
leonsenft requested changes Jul 1, 2025
View reviewed changes
Copy link
Contributor
@leonsenft leonsenft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with zod and suspect most of my questions stem from that unfamiliarity.

@mmalerba @leonsenft
Apply suggestions from code review
94d44f2 
Co-authored-by: Leon Senft <leonsenft@users.noreply.github.com>
@mmalerba mmalerba requested a review from leonsenft July 1, 2025 21:14
michael-small
michael-small reviewed Jul 1, 2025
View reviewed changes
michael-small
michael-small reviewed Jul 1, 2025
View reviewed changes
mmalerba and others added 2 commits July 1, 2025 16:25
@mmalerba @michael-small
Update packages/forms/experimental/test/web/standard_schema.spec.ts
7262a95 
Co-authored-by: michael-small <33669563+michael-small@users.noreply.github.com>
@mmalerba
fix return type docs
0470fdb
@mmalerba mmalerba merged commit fead94d into angular:prototype/signal-forms Jul 1, 2025
11 of 18 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Experimental Signal Forms Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-small michael-small michael-small left review comments

@leonsenft leonsenft leonsenft approved these changes

@kirjs kirjs Awaiting requested review from kirjs

@alxhub alxhub Awaiting requested review from alxhub

Assignees

@mmalerba mmalerba

Labels
area: forms target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
Experimental Signal Forms
Status: Done
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @leonsenft @michael-small
0