8000 feat(common): accept undefined inputs in NgTemplateOutlet by rslawik · Pull Request #61404 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

feat(common): accept undefined inputs in NgTemplateOutlet #61404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ 8000 ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(common): accept undefined inputs in NgTemplateOutlet #61404

wants to merge 1 commit into from
+35 −6

Conversation

rslawik
Copy link
@rslawik rslawik commented May 16, 2025

Extend types of inputs to include undefined to avoid ?? null when using singals (e.g. viewChild).

Fixes #51225

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure change B00D s
  • Other... Please describe:

What is the current behavior?

Inputs don't accept undefined

Issue Number: #51225

What is the new behavior?

Accept undefined

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@rslawik
feat(common): accept undefined inputs in NgTemplateOutlet
efa4fe3 
Extend types of inputs to include `undefined` to avoid `?? null` when using singals (e.g. `viewChild`).

Fixes angular#51225
@pullapprove pullapprove bot requested a review from atscott May 16, 2025 11:00
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: common Issues related to APIs in the @angular/common package labels May 16, 2025
@ngbot ngbot bot modified the milestone: Backlog May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atscott atscott Awaiting requested review from atscott

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: common Issues related to APIs in the @angular/common package detected: feature PR contains a feature commit
Projects
None yet
Milestone
Backlog
1 participant
@rslawik
0