8000 Fix docs styles when example viewer exceeds the width limit by Ahmed-Hakeem · Pull Request #61384 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

Fix docs styles when example viewer exceeds the width limit #61384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix docs styles when example viewer exceeds the width limit #61384

wants to merge 1 commit into from
+41 −16

Conversation

Ahmed-Hakeem
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

Issue Number: #61359

@pullapprove pullapprove bot requested a review from jelbourn May 16, 2025 01:07
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels May 16, 2025
@ngbot ngbot bot added this to the Backlog milestone May 16, 2025
@thePunderWoman thePunderWoman requested a review from JeanMeche May 16, 2025 07:55
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release adev: preview labels May 16, 2025
@github-actions GitHub Actions
Copy link

Deployed adev-preview for f353cd5 to: https://ng-dev-previews-fw--pr-angular-angular-61384-adev-prev-ivxdhkil.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche requested review from hawkgs and removed request for jelbourn May 16, 2025 11:10
@Ahmed-Hakeem
docs(docs-infra): fix docs pages overflow when specific example-viewe…
c568cfc 
…r exists

enforce content to be fluid until a specific max width, and rollback breakpoints to be applied when 1430px is the current win size
as widths between 1430px and 1431px will be broken
@Ahmed-Hakeem
Copy link
Contributor Author

I believe now it's much cleaner : ) ..... Thank you @JeanMeche for your note ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@hawkgs hawkgs Awaiting requested review from hawkgs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure 4A5D target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@Ahmed-Hakeem @JeanMeche @thePunderWoman
0