8000 fix(core): fakeAsync should not depend on module import order by atscott · Pull Request #61375 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

fix(core): fakeAsync should not depend on module import order #61375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): fakeAsync should not depend on module import order #61375

wants to merge 1 commit into from
+19 −29

Conversation

atscott
Copy link
Contributor
@atscott atscott commented May 15, 2025 •
edited
Loading

fakeAsync does not work if the zone-testing polyfill is included after
@angular/core/testing is loaded. This allows fakeAsync to work
even if the zone-testing is included later.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label May 15, 2025
@ngbot ngbot bot added this to the Backlog milestone May 15, 2025
@atscott atscott added the target: patch This PR is targeted for the next patch release label May 15, 2025
@atscott
fix(core): fakeAsync should not depend on module import order
5ff3569 
`fakeAsync` does not work if the zone-testing polyfill is included after
@angular/core/testing is loaded. This allows fakeAsync to work
even if the zone-testing is included later.
@atscott atscott changed the title Fake async fixes fix(core): fakeAsync should not depend on module import order May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@atscott @AndrewKushnir
0