refactor(devtools): switch default devtools font to material symbols #61281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
approved these changes
May 12, 2025
JeanMeche
reviewed
May 12, 2025
| @@ -99,6 +101,7 @@ export class DevToolsComponent implements OnInit, OnDestroy { | |||
| ngOnInit(): void { | |||
| this._themeService.initializeThemeWatcher(); | |||
| this._browserStyles.initBrowserSpecificStyles(); | |||
| this._matIconRegistry.setDefaultFontSetClass('material-symbols-outlined'); | |||
There was a problem hiding this comment.
@AleksanderBodurri Thoughts on moving the content of ngOnInit to the constructor and has the inject only the scope of the constructor ?
There was a problem hiding this comment.
Something like this?
constructor() {
inject(ThemeService).initializeThemeWatcher();
inject(BrowserStylesService).initBrowserSpecificStyles();
inject(MatIconRegistry).setDefaultFontSetClass('material-symbols-outlined');
}
devversion
approved these changes
May 14, 2025
third_party/fonts.google.com/material-symbols-outlined/BUILD.bazel
Outdated
Show resolved
Hide resolved
82a5660 to
5f6288d
Compare
update from Material Icons to Material Symbols, and use the local font copy instead of Google fonts to avoid version mismatches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some of the icons were missing in the final build of the signals graph pr because of version mismatches between Google fonts and our local font copy. I updated to material-symbols-outlined to fix this error and allow us to use new icons like
graph-2Issue Number: N/A
What is the new behavior?
We now consistently use material-symbols-outlined without downloading anything from Google fonts
Does this PR introduce a breaking change?
Other information