8000 refactor(core): only throw an error if component with async metadata … by JeanMeche · Pull Request #61230 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

refactor(core): only throw an error if component with async metadata … #61230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(core): only throw an error if component with async metadata … #61230

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

…is overriden.

This only really matters for tests that run with AOT.

@pullapprove pullapprove bot requested a review from atscott May 8, 2025 22:14
@JeanMeche JeanMeche requested a review from crisbeto May 8, 2025 22:14
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label May 8, 2025
@ngbot ngbot bot added this to the Backlog milestone May 8, 2025
@JeanMeche JeanMeche force-pushed the core/defer-async-metadata branch 3 times, most recently from dece655 to 5e5fc16 Compare May 8, 2025 22:31
@AndrewKushnir AndrewKushnir requested review from AndrewKushnir and removed request for atscott and crisbeto May 8, 2025 22:43
@JeanMeche JeanMeche force-pushed the core/defer-async-metadata branch 2 times, most recently from e5270b4 to 45ba049 Compare May 9, 2025 09:54
@JeanMeche JeanMeche marked this pull request as draft May 16, 2025 14:56
@JeanMeche JeanMeche force-pushed the core/defer-async-metadata branch 3 times, most recently from da9b562 to 9a0b704 Compare May 17, 2025 01:12
@JeanMeche
refactor(core): only throw an error if component with async metadata …
6e57959 
…is overriden.

This only really matters for tests that run with AOT.
@JeanMeche JeanMeche force-pushed the core/defer-async-metadata branch from 9a0b704 to 6e57959 Compare May 17, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: core Issues related to the framework runtime
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
1 participant
@JeanMeche
0