refactor: add a new version of the logic node #61079
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new version of logic node that is created via builders. The builder / actual logic node split allows the final logic for a node to be lazily merged together. My plan is to eventually swap this in for FieldLogicNode and have the schema methods (`validate`, `apply`, etc.) work with the builders. The FieldNode will then build its logic when it is first created. This should be the other main piece aside from relative paths which is needed to make self-referential logic work.
|
@mmalerba Could you fix the commits messages in this PR so we can have proper area labels assigned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new version of logic node that is created via builders. The builder / actual logic node split allows the final logic for a node to be lazily merged together.
My plan is to eventually swap this in for FieldLogicNode and have the schema methods (
validate,apply, etc.) work with the builders. The FieldNode will then build its logic when it is first created.This should be the other main piece aside from relative paths which is needed to make self-referential logic work.