8000 fix(core): properly handle app stabilization with defer blocks [patch] by alan-agius4 · Pull Request #61056 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

fix(core): properly handle app stabilization with defer blocks [patch] #61056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

fix(core): properly handle app stabilization with defer blocks [patch] #61056

wants to merge 6 commits into from
+8,916 −14

Conversation

alan-agius4
Copy link
Contributor

Patch version of #61040

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Apr 30, 2025
@pullapprove pullapprove bot requested a review from devversion April 30, 2025 07:34
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Apr 30, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 30, 2025
@alan-agius4 alan-agius4 mentioned this pull request Apr 30, 2025
Closed
@alan-agius4
Copy link
Contributor Author
alan-agius4 commented Apr 30, 2025 •
edited
Loading

caretaker note: the lint is the usual license check failure.

@alan-agius4 alan-agius4 added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 30, 2025
devversion
devversion previously approved these changes Apr 30, 2025
View reviewed changes
@alan-agius4 alan-agius4 force-pushed the pending-tasks-patch branch from 83eed66 to c13517c Compare April 30, 2025 08:41
@alan-agius4 alan-agius4 removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 30, 2025
thePunderWoman
thePunderWoman previously approved these changes Apr 30, 2025
View reviewed changes
@alan-agius4 alan-agius4 dismissed stale reviews from thePunderWoman and devversion via c1f056d April 30, 2025 08:58
@alan-agius4 alan-agius4 force-pushed the pending-tasks-patch branch from c13517c to c1f056d Compare April 30, 2025 08:58
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 30, 2025
@alan-agius4 alan-agius4 linked an issue Apr 30, 2025 that may be closed by this pull request
Bug: ssr + zoneless + defer + inputs fails to resolve input data on first render #61038
Closed
@alan-agius4
test: add integration test for defer with input on SSR with zones
1a0e8a3 
Add an integration test to verify defer block behavior with input handling during server-side rendering (SSR).

(cherry picked from commit 202fb1a)
@alan-agius4
test: add integration test for platform-server with zoneless
48cf46f 
Add an integration test to verify SSR with zoneless

(cherry picked from commit c88b29c)
@alan-agius4
test: disable platform-server tests that do not work with zoneless
b9e96ef 
A number of cases currently do not work with zoneless.

(cherry picked from commit 58f99a4)
@alan-agius4
8000 fix(core): properly handle app stabilization with defer blocks
feccb8d 
Previously, the app was marked as stable prematurely. For more details, see angular#61038 (comment)

Closes: angular#61038
(cherry picked from commit de649c9)
@alan-agius4
fixup! fix(core): properly handle app stabilization with defer blocks
9b21b61 
(cherry picked from commit b933c44)
@alan-agius4
fixup! fix(core): properly handle app stabilization with defer blocks
e9684a9
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 30, 2025
@alan-agius4 alan-agius4 force-pushed the pending-tasks-patch branch from c1f056d to e9684a9 Compare April 30, 2025 10:57
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 30, 2025
AndrewKushnir pushed a commit that referenced this pull request Apr 30, 2025
@alan-agius4 @AndrewKushnir
test: add integration test for defer with input on SSR with zones (#6…
0020fc6 
…1056)

Add an integration test to verify defer block behavior with input handling during server-side rendering (SSR).

(cherry picked from commit 202fb1a)

PR Close #61056
AndrewKushnir pushed a commit that referenced this pull request Apr 30, 2025
@alan-agius4 @AndrewKushnir
test: add integration test for platform-server with zoneless (#61056)
7945226 
Add an integration test to verify SSR with zoneless

(cherry picked from commit c88b29c)

PR Close #61056
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 400dbc5.

The changes were merged into the following branches: 19.2.x

AndrewKushnir pushed a commit that referenced this pull request Apr 30, 2025
@alan-agius4 @AndrewKushnir
test: disable platform-server tests that do not work with zoneless (#…
90b3355 
…61056)

A number of cases currently do not work with zoneless.

(cherry picked from commit 58f99a4)

PR Close #61056
AndrewKushnir pushed a commit that referenced this pull request Apr 30, 2025
@alan-agius4 @AndrewKushnir
fix(core): properly handle app stabilization with defer blocks (#61056)
400dbc5 
Previously, the app was marked as stable prematurely. For more details, see #61038 (comment)

Closes: #61038
(cherry picked from commit de649c9)

PR Close #61056
@alan-agius4 alan-agius4 deleted the pending-tasks-patch branch April 30, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Bug: ssr + zoneless + defer + inputs fails to resolve input data on first render
4 participants
@alan-agius4 @AndrewKushnir @thePunderWoman @devversion
0