8000 feat(core): rename afterRender to afterEveryRender and stabilize by pkozlowski-opensource · Pull Request #60999 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

feat(core): rename afterRender to afterEveryRender and stabilize #60999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

8000 Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(core): rename afterRender to afterEveryRender and stabilize #60999

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

This change renames the afterRender to afterEveryRender and marks the renamed API as stable.

BREAKING CHANGE: afterRender was renamed to afterEveryRender.

@pullapprove pullapprove bot requested review from alxhub, AndrewKushnir and kirjs April 25, 2025 09:51
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Apr 25, 2025
@ngbot ngbot bot modified the milestone: Backlog Apr 25, 2025
@pkozlowski-opensource pkozlowski-opensource added target: major This PR is targeted for the next major release state: blocked action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 25, 2025
@pkozlowski-opensource
Copy link
Member Author

Will require G3 cleanup before it can land

@pkozlowski-opensource pkozlowski-opensource self-assigned this Apr 25, 2025
@pkozlowski-opensource
feat(core): rename afterRender to afterEveryRender and stabilize
1d93ae1 
This change renames the afterRender to afterEveryRender and marks the
renamed API as stable.

BREAKING CHANGE: afterRender was renamed to afterEveryRender.
alxhub
alxhub approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member
@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott April 25, 2025 16:08
AndrewKushnir
AndrewKushnir approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor
@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pkozlowski-opensource pkozlowski-opensource added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer state: blocked labels Apr 25, 2025
@pkozlowski-opensource
Copy link
Member Author

caretaker note: This PR renames afterRender to afterEveryRender. G3 is done but it might have back-slided. If this is the case please don't revert but fix-forward instead by doing the rename.

@mmalerba
Copy link
Contributor

This PR was merged into the repository by commit d8fbb90.

The changes were merged into the following branches: main

@mmalerba mmalerba closed this in d8fbb90 Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxhub alxhub alxhub approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

@pkozlowski-opensource pkozlowski-opensource

Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v20 candidates
Development

Successfully merging this pull request may close these issues.
4 participants
@pkozlowski-opensource @mmalerba @alxhub @AndrewKushnir
0