8000 fix(common): issue a warning instead of an error when `NgOptimizedImage` exceeds the preload limit by alan-agius4 · Pull Request #60883 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

fix(common): issue a warning instead of an error when NgOptimizedImage exceeds the preload limit #60883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(common): issue a warning instead of an error when NgOptimizedImage exceeds the preload limit #60883

wants to merge 1 commit into from
+38 −28

Conversation

alan-agius4
Copy link
Contributor

This should not be treated as a hard error, as it doesn’t break the application but merely degrades performance.

Closes #60871

(cherry picked from commit 8f25d4a)

@alan-agius4
fix(common): issue a warning instead of an error when `NgOptimizedIma…
a741e34 
…ge` exceeds the preload limit

This should not be treated as a hard error, as it doesn’t break the application but merely degrades performance.

Closes angular#60871

(cherry picked from commit 8f25d4a)
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next 8000 patch release labels Apr 16, 2025
@pullapprove pullapprove bot requested a review from alxhub April 16, 2025 09:44
@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label Apr 16, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 16, 2025
@alan-agius4 alan-agius4 mentioned this pull request Apr 16, 2025
Closed
@alan-agius4 alan-agius4 removed the request for review from alxhub April 16, 2025 09:44
@kirjs
Copy link
Contributor
kirjs commented Apr 16, 2025

This PR was merged into the repository by commit 37ab681.

The changes were merged into the following branches: 19.2.x

kirjs pushed a commit that referenced this pull request Apr 16, 2025
@alan-agius4 @kirjs
fix(common): issue a warning instead of an error when `NgOptimizedIma…
37ab681 
…ge` exceeds the preload limit (#60883)

This should not be treated as a hard error, as it doesn’t break the application but merely degrades performance.

Closes #60871

(cherry picked from commit 8f25d4a)

PR Close #60883
@kirjs kirjs closed this Apr 16, 2025
@alan-agius4 alan-agius4 deleted the cherry-pick-optimize-image branch April 16, 2025 16:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-agius4 @kirjs @thePunderWoman
0