build: ensure material dependencies are properly linked for devtools #60822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
alan-agius4
approved these changes
Apr 10, 2025
alan-agius4
reviewed
Apr 10, 2025
alan-agius4
reviewed
Apr 10, 2025
This is a follow-up to the recent devtools linking change, leveraging the dedicated package that we are also using in the components repository; avoiding future duplication. The latest version of that package contains a fix for an issue where the linked bundles did not rewrite imports to shared chunks. Such imports need to also point to their linked variants.
97370ab to
7b18bd2
Compare
|
This PR was merged into the repository by commit 5c575a8. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the recent devtools linking change, leveraging the dedicated package that we are also using in the components repository; avoiding future duplication.
The latest version of that package contains a fix for an issue where the linked bundles did not rewrite imports to shared chunks.
Such imports need to also point to their linked variants.