10000 fix(core): properly handle the case where getSignalGraph is called on a componentless NodeInjector by AleksanderBodurri · Pull Request #60772 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

fix(core): properly handle the case where getSignalGraph is called on a componentless NodeInjector #60772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(core): properly handle the case where getSignalGraph is called on a componentless NodeInjector #60772

wants to merge 1 commit into from

Conversation

AleksanderBodurri
Copy link
Member

Previously this would throw an error on the assertLView when we try to discover the templateLView.

Now this properly returns null for the template consumer and continues discovering other effects on the injector.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Apr 7, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 7, 2025
AleksanderBodurri
AleksanderBodurri commented Apr 7, 2025
View reviewed changes
@AleksanderBodurri AleksanderBodurri force-pushed the fix-get-signal-graph-call-on-non-component-directives branch from e2f18db to b7b93c3 Compare April 14, 2025 14:08
@AleksanderBodurri AleksanderBodurri marked this pull request as ready for review April 14, 2025 14:09
@pullapprove pullapprove bot requested a review from atscott April 14, 2025 14:09
@AleksanderBodurri AleksanderBodurri requested review from dgp1130 and removed request for atscott April 14, 2025 14:11
@pullapprove pullapprove bot requested a review from atscott April 14, 2025 14:11
@AleksanderBodurri AleksanderBodurri added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 21, 2025
pkozlowski-opensource
pkozlowski-opensource requested changes Apr 22, 2025
View reviewed changes
Copy link
Member
@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AleksanderBodurri I think that this change will need a test - without a test it is not clear under which conditions the assert starts to fail. And there is a risk that we accidentally refactor the code in a way that breaks dev tools again.

@pkozlowski-opensource pkozlowski-opensource added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Apr 22, 2025
@AleksanderBodurri AleksanderBodurri force-pushed the fix-get-signal-graph-call-on-non-component-directives branch 2 times, most recently from fa7bbf3 to 94d9e44 Compare May 5, 2025 06:25
@AleksanderBodurri AleksanderBodurri force-pushed the fix-get-signal-graph-call-on-non-component-directives branch from 94d9e44 to 2a30cac Compare May 5, 2025 06:28
@AleksanderBodurri
Copy link
Member Author

@AleksanderBodurri I think that this change will need a test - without a test it is not clear under which conditions the assert starts to fail. And there is a risk that we accidentally refactor the code in a way that breaks dev tools again.

Good point 🙏 Added another test case for getSignalGraph that goes through the component-less NodeInjector case

@AleksanderBodurri AleksanderBodurri added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 5, 2025
JeanMeche
JeanMeche reviewed May 5, 2025
View reviewed changes
@AleksanderBodurri AleksanderBodurri force-pushed the fix-get-signal-graph-call-on-non-component-directives branch from 2a30cac to 7b264ec Compare May 5, 2025 14:11
JeanMeche
JeanMeche reviewed May 5, 2025
View reviewed changes
@AleksanderBodurri AleksanderBodurri force-pushed the fix-get-signal-graph-call-on-non-component-directives branch from 7b264ec to 3683156 Compare May 5, 2025 14:43
dgp1130
dgp1130 approved these changes May 19, 2025
View reviewed changes
@milomg milomg mentioned this pull request May 21, 2025
Closed
14 tasks
@JeanMeche JeanMeche removed their request for review June 3, 2025 12:28
@atscott atscott removed their request for review June 3, 2025 17:57
@AleksanderBodurri AleksanderBodurri force-pushed the fix-get-signal-graph-call-on-non-component-directives branch 2 times, most recently from 34cb547 to 3353fa5 Compare June 4, 2025 00:13
dgp1130
dgp1130 approved these changes Jun 4, 2025
View reviewed changes
@AleksanderBodurri AleksanderBodurri force-pushed the fix-get-signal-graph-call-on-non-component-directives branch 4 times, most recently from 6bfc98e to f7341af Compare June 4, 2025 00:52
@AleksanderBodurri
fix(core): properly handle the case where getSignalGraph is called on…
54283a5 
… a componentless NodeInjector

Previously this would throw an error on the assertLView when we try to discover the templateLView.

Now this properly returns null for the template consumer and continues discovering other effects on the injector.
@AleksanderBodurri AleksanderBodurri force-pushed the fix-get-signal-graph-call-on-non-component-directives branch from f7341af to 54283a5 Compare June 4, 2025 00:55
@AleksanderBodurri AleksanderBodurri requested a review from dgp1130 June 4, 2025 00:59
@AleksanderBodurri AleksanderBodurri added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 4, 2025
@ngbot
Copy link
ngbot bot commented Jun 4, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "pullapprove" is failing
    pending status "google-internal-tests" is pending
    pending 2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kirjs
Copy link
Contributor
kirjs commented Jun 4, 2025

This PR was merged into the repository by commit 9a8f4f1.

The changes were merged into the following branches: main, 20.0.x

8000

kirjs pushed a commit that referenced this pull request Jun 4, 2025
@AleksanderBodurri @kirjs
fix(core): properly handle the case where getSignalGraph is called on…
b4ed62d 
… a componentless NodeInjector (#60772)

Previously this would throw an error on the assertLView when we try to discover the templateLView.

Now this properly returns null for the template consumer and continues discovering other effects on the injector.

PR Close #60772
@kirjs kirjs closed this in 9a8f4f1 Jun 4, 2025
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@dgp1130 dgp1130 dgp1130 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@AleksanderBodurri @kirjs @pkozlowski-opensource @JeanMeche @dgp1130
0