8000 refactor(core): remove the `phase` prop from `AfterRenderOptions` by JeanMeche · Pull Request #60641 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

refactor(core): remove the phase prop from AfterRenderOptions #60641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(core): remove the phase prop from AfterRenderOptions #60641

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

The AfterRenderPhase enum now becomes private, it isn't exported anymore.

@pullapprove pullapprove bot requested a review from AndrewKushnir March 31, 2025 17:32
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Mar 31, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 31, 2025
@JeanMeche JeanMeche force-pushed the AfterRenderOptions-phase branch 2 times, most recently from e0f9f4f to d9a245d Compare March 31, 2025 18:08
@JeanMeche
refactor(core): remove the phase prop from AfterRenderOptions
c6e9542 
The `AfterRenderPhase` enum now becomes private, it isn't exported anymore.
@JeanMeche JeanMeche force-pushed the AfterRenderOptions-phase branch from d9a245d to c6e9542 Compare March 31, 2025 18:09
@JeanMeche JeanMeche requested review from pkozlowski-opensource and removed request for AndrewKushnir March 31, 2025 18:09
@AndrewKushnir AndrewKushnir modified the milestones: Backlog, v20 candidates Apr 2, 2025
pkozlowski-opensource
pkozlowski-opensource reviewed Apr 7, 2025
View reviewed changes
Copy link
Member
@pkozlowski-opensource pkozlowski-opensource left a comment •
edited by JeanMeche
Loading
8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from crisbeto April 7, 2025 17:49
jelbourn
jelbourn approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member
@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

mmalerba
mmalerba approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor
@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release state: blocked and removed action: merge The PR is ready for merge by the caretaker labels Apr 8, 2025
@JeanMeche
Copy link
Member Author
JeanMeche commented Apr 8, 2025 •
edited
Loading

(Found usages in g3 : CL)

alxhub
alxhub approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member
@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@e-oz
Copy link
e-oz commented Apr 8, 2025

isn’t it a breaking change? we use it a lot

@JeanMeche
Copy link
Member Author
JeanMeche commented Apr 8, 2025 •
edited
Loading

@e-oz This is a devPreview API and has been deprecated in v19 already.

@e-oz
Copy link
e-oz commented Apr 9, 2025

Ah, you are removing the phase field itself, not the phases. Sorry, misunderstood.

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels Apr 9, 2025
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Apr 9, 2025
@JeanMeche
Copy link
Member Author

G3 has been cleaned-up. We're good to go.

@JeanMeche JeanMeche mentioned this pull request Apr 9, 2025
Closed
@atscott
Copy link
Contributor
atscott commented Apr 9, 2025

This PR was merged into the repository by commit 36ae560.

The changes were merged into the following branches: main

@atscott atscott closed this in 36ae560 Apr 9, 2025
JeanMeche added a commit to JeanMeche/angular that referenced this pull request May 8, 2025
@JeanMeche
refactor(core): cleanup after* option types
27f93ba 
The `phase` property of `AfterRenderOptions`  was removed in angular#60641.
@JeanMeche JeanMeche mentioned this pull request May 8, 2025
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@jelbourn jelbourn jelbourn approved these changes

@alxhub alxhub alxhub approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v20 candidates
Development

Successfully merging this pull request may close these issues.
8 participants
@JeanMeche @e-oz @atscott @jelbourn @pkozlowski-opensource @alxhub @mmalerba @AndrewKushnir
0