8000 refactor(devtools): mark devtools components onpush by sheikalthaf · Pull Request #59552 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

refactor(devtools): mark devtools components onpush #59552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occas 8000 ionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(devtools): mark devtools components onpush #59552

wants to merge 1 commit into from

Conversation

sheikalthaf
Copy link
Contributor

mark all the devtools components onpush because now are only depending on signals for template updates

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@sheikalthaf
refactor(devtools): mark devtools components onpush
846d757 
mark all the devtools components onpush because now are only depending on signals for template updates
@pullapprove pullapprove bot requested a review from mgechev January 16, 2025 03:26
@ngbot ngbot bot added this to the Backlog milestone Jan 16, 2025
@sheikalthaf
Copy link
Contributor Author

@dgp1130 @AleksanderBodurri can you review this PR.

@AleksanderBodurri
Copy link
Member
AleksanderBodurri commented Jan 27, 2025 •
edited
Loading

Thanks @sheikalthaf

Switching to OnPush for these components is not a priority for us right now, It's a bit risky to change these and risk breaking rendering behaviour given that there isn't too much value in doing so.

I did notice while testing this, a bug in the rendering logic for the component explorer when a component that is currently selected is removed. I wonder if this is a bug on the main branch as well 🤔 I will investigate on my end

@AleksanderBodurri AleksanderBodurri requested review from AleksanderBodurri and removed request for mgechev January 27, 2025 23:32
@thePunderWoman thePunderWoman requested a review from dgp1130 May 16, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderBodurri AleksanderBodurri Awaiting requested review from AleksanderBodurri

@dgp1130 dgp1130 Awaiting requested review from dgp1130

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: devtools
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@sheikalthaf @AleksanderBodurri
0