10000 feat(compiler-cli): add diagnostic for uninvoked functions in text interpolation by RafaelJCamara · Pull Request #59191 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

feat(compiler-cli): add diagnostic for uninvoked functions in text interpolation #59191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(compiler-cli): add diagnostic for uninvoked functions in text interpolation #59191

wants to merge 1 commit into from

Conversation

RafaelJCamara
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

We don't perform this check whenever we have an uninvoked function in a text interpolation.

Issue Number: #59157

What is the new behavior?

Whenever we have an uninvoked function in a text interpolation, a warning is triggered (NG8114).

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from alxhub December 14, 2024 10:32
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Dec 14, 2024
JeanMeche
JeanMeche reviewed Dec 14, 2024
View reviewed changes
@JeanMeche
Copy link
Member

Could you also make sure to check the linter failures, thank you.

@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 14, 2024 •
edited
Loading

Deployed adev-preview for b3607ab to: https://ng-dev-previews-fw--pr-angular-angular-59191-adev-prev-ehyguwsu.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche
Copy link
Member

Also, we need to add the entry to adev/src/content/reference/extended-diagnostics/overview.md.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Dec 18, 2024
@ngbot ngbot bot added this to the Backlog milestone Dec 18, 2024
@RafaelJCamara
Copy link
Contributor Author

@JeanMeche I think I've addressed all the comments!

JeanMeche
JeanMeche reviewed Dec 18, 2024
View reviewed changes
@RafaelJCamara
Copy link
Contributor Author

Whenever you have time, please look at the new changes @JeanMeche!

JoostK
JoostK reviewed Dec 19, 2024
View reviewed changes
Copy link
Member
@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect these points may have originated in the signal check, but mentioning them here anyway.

@RafaelJCamara RafaelJCamara requested a review from JoostK December 19, 2024 19:21
@RafaelJCamara RafaelJCamara requested a review from JoostK December 19, 2024 21:54
@RafaelJCamara
Copy link
Contributor Author

@JeanMeche @JoostK Changes have been applied and are ready to be blasted with another review!

@RafaelJCamara
Copy link
Contributor Author

@alxhub @JeanMeche @JoostK Do you think this is ready for a review?

@jelbourn jelbourn mentioned this pull request Jan 29, 2025
Open
JoostK
JoostK reviewed Feb 6, 2025
View reviewed changes
Copy link
Member
@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct for me

@JeanMeche
Copy link
Member

Case you rebase your PR and take the previous comments into account ? Thank you.

@JeanMeche JeanMeche force-pushed the RafaelJCamara/59157-func-text-interpolation branch from 8230854 to 192b848 Compare March 4, 2025 21:20
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 4, 2025
@JeanMeche JeanMeche force-pushed the RafaelJCamara/59157-func-text-interpolation branch 2 times, most recently from b648bc4 to 04791c9 Compare March 4, 2025 21:36
@angular-robot angular-robot bot removed the area: docs Related to the documentation label Mar 4, 2025
@JeanMeche JeanMeche removed their request for review March 4, 2025 21:36
@JeanMeche
Copy link
Member

No signs from OP on github over the past few months, I've picked over the PR to move it foward.

@JeanMeche JeanMeche force-pushed the RafaelJCamara/59157-func-text-interpolation branch 2 times, most recently from fec1662 to e39f805 Compare March 4, 2025 22:16
@RafaelJCamara
Copy link
Contributor Author
RafaelJCamara commented Apr 22, 2025 •
edited
Loading

Please do it @JeanMeche , I don't have much time now. Thanks :)

@thePunderWoman thePunderWoman marked this pull request as draft May 21, 2025 15:31
@thePunderWoman thePunderWoman removed the request for review from alxhub June 3, 2025 11:07
@JeanMeche JeanMeche force-pushed the RafaelJCamara/59157-func-text-interpolation branch 2 times, most recently from e0ca7b4 to 2b289eb Compare June 5, 2025 08:24
@thePunderWoman thePunderWoman added the target: patch This PR is targeted for the next patch release label Jun 5, 2025
@thePunderWoman thePunderWoman force-pushed the RafaelJCamara/59157-func-text-interpolation branch from 2b289eb to 2bb8efe Compare June 5, 2025 12:50
@JeanMeche JeanMeche force-pushed the RafaelJCamara/59157-func-text-interpolation branch from 2bb8efe to 5a8fae9 Compare June 5, 2025 13:34
@JeanMeche JeanMeche added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 27, 2025
@RafaelJCamara @JeanMeche
feat(compiler-cli): add diagnostic for uninvoked functions in text in…
b3607ab 
…terpolation

This commit adds a new extended diagnostic to detect uninvoked functions in text interpolation.
@JeanMeche JeanMeche force-pushed the RafaelJCamara/59157-func-text-interpolation branch from 5a8fae9 to b3607ab Compare June 27, 2025 09:54
@JeanMeche JeanMeche marked this pull request as ready for review June 27, 2025 09:55
@JeanMeche JeanMeche requested a review from crisbeto June 27, 2025 11:12
@JeanMeche
Copy link
Member

The last fix CL from the previous TGP was submitted.

This should be good to go.

@JeanMeche
Copy link
Member

TESTED=TGP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoostK JoostK JoostK left review comments

@JeanMeche JeanMeche JeanMeche left review comments

@crisbeto crisbeto Awaiting requested review from crisbeto

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
adev: preview area: compiler Issues related to `ngc`, Angular's template compiler detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
-->
Development

Successfully merging this pull request may close these issues.
4 participants
@RafaelJCamara @JeanMeche @JoostK @thePunderWoman
0