8000 feat(compiler): support the `in` keyword in Binary expression by JeanMeche · Pull Request #58432 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

feat(compiler): support the in keyword in Binary expression #58432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service 8000 and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(compiler): support the in keyword in Binary expression #58432

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member
@JeanMeche JeanMeche commented Oct 30, 2024 •
edited
Loading

This commit adds the support for the in keyword as a relational operator, with the same precedence as the other relational operators (<,>, <=, >=).

As a bigger picture, adding this brings us toward

@pullapprove pullapprove bot requested a review from AndrewKushnir October 30, 2024 17:31
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Oct 30, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 30, 2024
@JeanMeche JeanMeche requested review from alxhub and crisbeto and removed request for AndrewKushnir October 30, 2024 17:33
@angular-robot angular-robot bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 30, 2024
@angular-robot angular-robot bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 31, 2024
@JeanMeche JeanMeche modified the milestones: Backlog, v20 candidates Oct 31, 2024
@JeanMeche JeanMeche force-pushed the in-operator branch 3 times, most recently from 4e8c96a to 8041fb9 Compare February 23, 2025 17:52
@JeanMeche JeanMeche changed the title refactor(compiler): support the in keyword in Binary expression feat(compiler): support the in keyword in Binary expression Feb 23, 2025
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Feb 23, 2025
@JeanMeche JeanMeche added feature Issue that requests a new feature breaking changes labels Feb 23, 2025
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Feb 23, 2025
@JeanMeche JeanMeche removed detected: feature PR contains a feature commit detected: breaking change PR contains a commit with a breaking change labels Feb 23, 2025
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit labels Feb 23, 2025
@JeanMeche JeanMeche force-pushed the in-operator branch 2 times, most recently from 7ff4cb0 to b6c32c3 Compare March 28, 2025 13:20
@JeanMeche JeanMeche force-pushed the in-operator branch 4 times, most recently from 8d47aae to 111aaff Compare April 14, 2025 17:27
@JeanMeche
feat(compiler): support the in keyword in Binary expression
62786a6 
This commit adds the support for the `in` keyword as a relational operator, with the same precedence as the other relational operators (<,>, <=, >=)

BREAKING CHANGE: 'in' in an expression now refers to the operator
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 22, 2025
@JeanMeche JeanMeche removed the request for review from alxhub April 22, 2025 14:01
@pkozlowski-opensource
Copy link
A520
Member

This PR was merged into the repository by commit 1b8e7ab.

The changes were merged into the following branches: main

@JeanMeche JeanMeche deleted the in-operator branch April 22, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wartab wartab wartab left review comments

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler breaking changes detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit feature Issue that requests a new feature target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v20 candidates
Development

Successfully merging this pull request may close these issues.
4 participants
@JeanMeche @pkozlowski-opensource @crisbeto @wartab
0