8000 fix(core): cleanup `rxResource` abort listener by arturovt · Pull Request #58306 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

fix(core): cleanup rxResource abort listener #58306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you acc 8000 ount related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): cleanup rxResource abort listener #58306

wants to merge 1 commit into from
+5 −1

Conversation

arturovt
Copy link
Contributor
@arturovt arturovt commented Oct 22, 2024 •
edited
Loading

The observable terminates immediately when error is called, and no further emissions or completion notifications occur. Thus, we have to remove the abort listener in both the error and complete notifications.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Oct 22, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 22, 2024
@arturovt arturovt marked this pull request as ready for review October 22, 2024 17:37
@AndrewKushnir AndrewKushnir requested a review from alxhub October 22, 2024 21:23
@pkozlowski-opensource pkozlowski-opensource self-assigned this Oct 23, 2024
pkozlowski-opensource
pkozlowski-opensource requested changes Oct 23, 2024
View reviewed changes
Copy link
Member
@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/angular/angular/pull/58306/files#r1812963772

@arturovt arturovt force-pushed the fix/rx-resource-abort-listener branch from 961a4d7 to 62e6436 Compare October 25, 2024 09:36
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 25, 2024
@arturovt arturovt force-pushed the fix/rx-resource-abort-listener branch from 62e6436 to 9e420c9 Compare November 28, 2024 17:01
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 28, 2024
@ngbot ngbot bot modified the milestones: v19.1 candidates, Backlog Nov 28, 2024
@arturovt arturovt force-pushed the fix/rx-resource-abort-listener branch from 9e420c9 to 5de8be9 Compare January 7, 2025 13:07
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Jan 7, 2025
@arturovt arturovt force-pushed the fix/rx-resource-abort-listener branch 2 times, most recently from 30e8751 to c679488 Compare January 28, 2025 09:53
@arturovt arturovt force-pushed the fix/rx-resource-abort-listener branch from c679488 to 29323a6 Compare February 15, 2025 23:31
@arturovt arturovt force-pushed the fix/rx-resource-abort-listener branch from 29323a6 to 577e7d8 Compare February 24, 2025 16:49
@arturovt arturovt force-pushed the fix/rx-resource-abort-listener branch from 577e7d8 to a9ef582 Compare March 5, 2025 17:34
@arturovt arturovt force-pushed the fix/rx-resource-abort-listener branch from a9ef582 to 61ff1f3 Compare April 25, 2025 18:17
@thePunderWoman thePunderWoman removed the request for review from alxhub May 2, 2025 09:05
@arturovt arturovt force-pushed the fix/rx-resource-abort-listener branch from 61ff1f3 to e03ab38 Compare May 3, 2025 10:38
@arturovt arturovt force-pushed the fix/rx-resource-abort-listener branch 2 times, most recently from 0153139 to cb59014 Compare May 12, 2025 09:51
@arturovt
fix(core): cleanup rxResource abort listener
5d928b2 
The observable terminates immediately when `error` is called, and no further emissions or completion notifications occur. Thus, we have to remove the `abort` listener in both the `error` and `complete` notifications.
@arturovt arturovt force-pushed the fix/rx-resource-abort-listener branch from cb59014 to 5d928b2 Compare May 17, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkozlowski-opensource pkozlowski-opensource Awaiting requested review from pkozlowski-opensource

Requested changes must be addressed to merge this pull request.

Assignees

@pkozlowski-opensource pkozlowski-opensource

Labels
area: core Issues related to the framework runtime
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@arturovt @pkozlowski-opensource @AndrewKushnir
0