fix(common): Don't include statusText in HttpErrorResponse.message, deprecate HttpResponseBase.statusText #58080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
We'll need to update our golden files, for this please run Also please include a |
…eprecate HttpResponseBase.statusText Since HTTP/2, responses no longer contain a status text besides the status code, which caused our default value of 'OK' to be used in HttpErrorResponse.message. As discussed in angular#57580, we are opting to not change the default value to match the fetch spec (https://fetch.spec.whatwg.org/#concept-response-status-message), instead, we are deprecating the statusText field, and not using it in our own code. DEPRECATED: HttpResponseBase.statusText This field is usually populated with OK by default, and overwritten by what a remote HTTP server responds with on the status line. Since HTTP/2, we aren't guaranteed to have a value for this on the status line, meaning this value gets stuck at OK. If you need this field for display purposes, it is recommended to retrieve a selection from RFC9110 (or future RFCs) yourself. For other purposes, an HttpResponseCode enum is also provided at common/http. Fixes angular#23334
|
any updates on this PR ? |
|
@gorvk not from my end. All reque 8000 sted changes have been made so far, so it has just been sitting here, waiting for further feedback, approval or a close. |
thePunderWoman
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since HTTP/2, responses no longer contain a status text besides the status code, which caused our default value of 'OK' to be used in HttpErrorResponse.message. As discussed in #57580, we are opting to not change the default value to match the fetch spec (https://fetch.spec.whatwg.org/#concept-response-status-message), instead, we are deprecating the statusText field, and not using it in our own code.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #23334
What is the new behavior?
The
HttpResponseBase.statusTextfield is deprecated, and it is not used inHttpErrorResponse.messageanymore.Does this PR introduce a breaking change?
Other information
This was discussed in #57580.