8000 fix(elements): support host directives inputs/outputs by chintankavathia · Pull Request #57624 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

fix(elements): support host directives inputs/outputs #57624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(elements): support host directives inputs/outputs #57624

wants to merge 1 commit into from

Conversation

chintankavathia
Copy link
Contributor

allow setting inputs/outputs which are defined on host directive applied to that custom element component.

Fixes #53193

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #53193

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from AndrewKushnir September 2, 2024 11:32
@angular-robot angular-robot bot added the area: elements Issues related to Angular Elements label Sep 2, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 2, 2024
@chintankavathia chintankavathia force-pushed the host-directives-custom-elements branch from 102c3db to 47407e2 Compare September 2, 2024 11:35
@chintankavathia chintankavathia marked this pull request as draft September 2, 2024 12:49
@AndrewKushnir AndrewKushnir removed their request for review September 3, 2024 01:59
@chintankavathia chintankavathia marked this pull request as ready for review September 3, 2024 06:36
@pullapprove pullapprove bot requested a review from AndrewKushnir September 3, 2024 06:36
@chintankavathia chintankavathia force-pushed the host-directives-custom-elements branch from 5593cff to 97f9fe1 Compare September 4, 2024 05:25
@chintankavathia
Copy link
Contributor Author

Hey @crisbeto, is there a plan to support this use case? If not, we should mention this limitation in our @angular/elements docs somewhere. Thank you!

@chintankavathia chintankavathia force-pushed the host-directives-custom-elements branch from 97f9fe1 to ff9a67b Compare November 5, 2024 06:26
@chintankavathia chintankavathia mentioned this pull request Nov 5, 2024
Closed
@thePunderWoman thePunderWoman marked this pull request as draft May 21, 2025 15:28
@chintankavathia chintankavathia force-pushed the host-directives-custom-elements branch from ff9a67b to 1aa514a Compare June 6, 2025 07:47
@chintankavathia chintankavathia marked this pull request as ready for review June 6, 2025 07:51
@pullapprove pullapprove bot requested a review from AndrewKushnir June 6, 2025 07:51
@thePunderWoman thePunderWoman requested review from crisbeto and removed request for AndrewKushnir June 27, 2025 13:44
@chintankavathia
fix(elements): support host directives inputs/outputs
d30a247 
allow setting inputs/outputs which are defined on host directive applied to that custom element component.

Fixes angular#53193
@chintankavathia chintankavathia force-pushed the host-directives-custom-elements branch from 1aa514a to d30a247 Compare June 27, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: elements Issues related to Angular Elements
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Component with hostDirectives doesn't bind input outputs of directive when used as custom element
1 participant
@chintankavathia
0