E5EF fix(benchpress): adjust supported browser names for headless chrome [fixit] by pkozlowski-opensource · Pull Request #56360 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

fix(benchpress): adjust supported browser names for headless chrome [fixit] #56360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pkozlowski-opensource wants to merge 1 commit into from
Closed

fix(benchpress): adjust supported browser names for headless chrome [fixit] #56360

Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/benchpress/src/webdriver/chrome_driver_extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,11 @@ export class ChromeDriverExtension extends WebDriverExtension {
}

override supports(capabilities: {[key: string]: any}): boolean {
return this._majorChromeVersion >= 44 && capabilities['browserName'].toLowerCase() === 'chrome';
const browserName = capabilities['browserName'].toLowerCase();
return (
this._majorChromeVersion >= 44 &&
(browserName === 'chrome' || browserName === 'chrome-headless-shell')
);
}
}

Expand Down
13 changes: 12 additions & 1 deletion packages/benchpress/test/webdriver/chrome_driver_extension_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ describe('chrome driver extension', () => {
const CHROME45_USER_AGENT =
'"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2499.0 Safari/537.36"';

const HEADLESSCHROME124_USER_AGENT =
'"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/124.0.6314.0 Safari/537.36"';

let log: any[];
let extension: ChromeDriverExtension;

Expand Down Expand Up @@ -437,8 +440,16 @@ describe('chrome driver extension', () => {

it('should match chrome browsers', () => {
expect(createExtension().supports({'browserName': 'chrome'})).toBe(true);

expect(createExtension().supports({'browserName': 'Chrome'})).toBe(true);
expect(createExtension().supports({'browserName': 'chrome-headless-shell'})).toBe(true);
});

it('should parse chrome version from user agent', () => {
expect(
createExtension(null, HEADLESSCHROME124_USER_AGENT).supports({
'browserName': 'chrome-headless-shell',
}),
).toBe(true);
});
});
});
Expand Down
0