8000 refactor(core): feature for potential zoneless-compatibility debug check by atscott · Pull Request #55663 · angular/angular · GitHub
[go: up one dir, main page]

Skip to content

refactor(core): feature for potential zoneless-compatibility debug check #55663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor
@atscott atscott commented May 3, 2024

This commit adds a feature that might be useful for determining if an application is zoneless-ready. The way this works is generally only useful right now when zoneless is enabled. Some version of this may be useful in the future as a general configuration option to change detection to make checkNoChanges pass always exhaustive as an opt-in to address #45612.

@atscott atscott added the target: rc This PR is targeted for the next release-candidate label May 3, 2024
@atscott atscott force-pushed the zonelesswithzonechecknochanges branch 7 times, most recently from 5a84965 to 1f5bc65 Compare May 3, 2024 19:32
@atscott atscott marked this pull request as ready for review May 3, 2024 19:35
@atscott atscott requested a review from alxhub May 3, 2024 21:23
@atscott atscott force-pushed the zonelesswithzonechecknochanges branch 2 times, most recently from 00b0048 to 84da2d8 Compare May 6, 2024 18:57
@atscott atscott changed the title refactor(core): private feature for potential zoneless-compatibility debug check refactor(core): feature for potential zoneless-compatibility debug check May 6, 2024
Copy link
Contributor
@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api, fw-core

@pullapprove pullapprove bot requested a review from AndrewKushnir May 7, 2024 02:49
@atscott atscott force-pushed the zonelesswithzonechecknochanges branch from 84da2d8 to d16bff2 Compare May 7, 2024 18:12
This commit adds a feature that is useful for determining if an
application is zoneless-ready. The way this works is generally only
useful right now when zoneless is enabled. Some version of this may be useful in
the future as a general configuration option to change detection to make
`checkNoChanges` pass always exhaustive as an opt-in to address angular#45612.

Because this is an experimental, debug-only feature, it is okay to merge
during the RC period.
@atscott atscott force-pushed the zonelesswithzonechecknochanges branch from d16bff2 to c06bb1c Compare May 7, 2024 19:18
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label May 7, 2024
Copy link
Contributor
@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit ca6cdcd.

AndrewKushnir pushed a commit that referenced this pull request May 7, 2024
…eck (#55663)

This commit adds a feature that is useful for determining if an
application is zoneless-ready. The way this works is generally only
useful right now when zoneless is enabled. Some version of this may be useful in
the future as a general configuration option to change detection to make
`checkNoChanges` pass always exhaustive as an opt-in to address #45612.

Because this is an experimental, debug-only feature, it is okay to merge
during the RC period.

PR Close #55663
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0