fix(router): add customRouteProcessor wip #53312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tieppt
reviewed
Dec 1, 2023
| const c = children ? {...r, children} : {...r}; | ||
| if ((!c.component && !c.loadComponent) && (children || c.loadChildren) && | ||
| (c.outlet && c.outlet !== PRIMARY_OUTLET)) { | ||
| c.component = EmptyOutletComponent; | ||
| } | ||
|
|
||
| if (customRouteProcessor) { |
There was a problem hiding this comment.
I think we can check if this variable is a function instead
if (typeof customRouteProcessor === 'function') {}| * Makes a copy of the config and adds any default required properties and apply the custom route | ||
| * processor. | ||
| */ | ||
| export function standardizeConfig(r: Route, customRouteProcessor?: (r: Route) => Route): Route { |
There was a problem hiding this comment.
I think you can extract this type to use in both places:
type CustomRouteProcessorFn = (route: Route) => Route;| * processor. | ||
| */ | ||
| export function standardizeConfig(r: Route, customRouteProcessor?: (r: Route) => Route): Route { | ||
| const children = r.children && r.children.map(x => standardizeConfig(x, customRouteProcessor)); |
There was a problem hiding this comment.
Maybe, we can use Optional chaining for this one.
Suggested change
| const children = r.children && r.children.map(x => standardizeConfig(x, customRouteProcessor)); | |
| const children = r.children?.map(x => standardizeConfig(x, customRouteProcessor)); |
|
Closing. As discussed elsewhere, this needs more design. Additionally, the linked issue would be solved by #51532 which I think would be a much more intuitive and discoverable way of doing it. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #31800
What is the new behavior?
The devs can provide a function that will be called everytime the router processes some routes, either in app startup, or when loadComponent / loadChildren resolves.