8000 refactor(core): cleanup `after*` option types (#61216) · angular/angular@0995cb7 · GitHub
[go: up one dir, main page]
Skip to content

Commit 0995cb7

Browse files
JeanMechethePunderWoman
JeanMeche
authored and
thePunderWoman
committed
refactor(core): cleanup after* option types (#61216)
The `phase` property of `AfterRenderOptions` was removed in #60641. PR Close #61216
1 parent d59ed60 commit 0995cb7

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

‎goldens/public-api/core/index.api.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export function afterEveryRender<E = never, W = never, M = never>(spec: {
3030
write?: (...args: ɵFirstAvailable<[E]>) => W;
3131
mixedReadWrite?: (...args: ɵFirstAvailable<[W, E]>) => M;
3232
read?: (...args: ɵFirstAvailable<[M, W, E]>) => void;
33-
}, options?: Omit<AfterRenderOptions, 'phase'>): AfterRenderRef;
33+
}, options?: AfterRenderOptions): AfterRenderRef;
3434

3535
// @public
3636
export function afterEveryRender(callback: VoidFunction, options?: AfterRenderOptions): AfterRenderRef;
@@ -41,21 +41,21 @@ export function afterNextRender<E = never, W = never, M = never>(spec: {
4141
write?: (...args: ɵFirstAvailable<[E]>) => W;
4242
mixedReadWrite?: (...args: ɵFirstAvailable<[W, E]>) => M;
4343
read?: (...args: ɵFirstAvailable<[M, W, E]>) => void;
44-
}, options?: Omit<AfterRenderOptions, 'phase'>): AfterRenderRef;
44+
}, options?: AfterRenderOptions): AfterRenderRef;
4545

4646
// @public
4747
export function afterNextRender(callback: VoidFunction, options?: AfterRenderOptions): AfterRenderRef;
4848

4949
// @public
50-
export function afterRenderEffect(callback: (onCleanup: EffectCleanupRegisterFn) => void, options?: Omit<AfterRenderOptions, 'phase'>): AfterRenderRef;
50+
export function afterRenderEffect(callback: (onCleanup: EffectCleanupRegisterFn) => void, options?: AfterRenderOptions): AfterRenderRef;
5151

5252
// @public
5353
export function afterRenderEffect<E = never, W = never, M = never>(spec: {
5454
earlyRead?: (onCleanup: EffectCleanupRegisterFn) => E;
5555
write?: (...args: [...ɵFirstAvailableSignal<[E]>, EffectCleanupRegisterFn]) => W;
5656
mixedReadWrite?: (...args: [...ɵFirstAvailableSignal<[W, E]>, EffectCleanupRegisterFn]) => M;
5757
read?: (...args: [...ɵFirstAvailableSignal<[M, W, E]>, EffectCleanupRegisterFn]) => void;
58-
}, options?: Omit<AfterRenderOptions, 'phase'>): AfterRenderRef;
58+
}, options?: AfterRenderOptions): AfterRenderRef;
5959

6060
// @public
6161
export interface AfterRenderOptions {

‎packages/core/src/render3/after_render/hooks.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ export function afterEveryRender<E = never, W = never, M = never>(
138138
mixedReadWrite?: (...args: ɵFirstAvailable<[W, E]>) => M;
139139
read?: (...args: ɵFirstAvailable<[M, W, E]>) => void;
140140
},
141-
options?: Omit<AfterRenderOptions, 'phase'>,
141+
options?: AfterRenderOptions,
142142
): AfterRenderRef;
143143

144144
/**
@@ -314,7 +314,7 @@ export function afterNextRender<E = never, W = never, M = never>(
314314
mixedReadWrite?: (...args: ɵFirstAvailable<[W, E]>) => M;
315315
read?: (...args: ɵFirstAvailable<[M, W, E]>) => void;
316316
},
317-
options?: Omit<AfterRenderOptions, 'phase'>,
317+
options?: AfterRenderOptions,
318318
): AfterRenderRef;
319319

320320
/**

‎packages/core/src/render3/reactivity/after_render_effect.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ export type ɵFirstAvailableSignal<T extends unknown[]> = T extends [infer H, ..
271271
*/
272272
export function afterRenderEffect(
273273
callback: (onCleanup: EffectCleanupRegisterFn) => void,
274-
options?: Omit<AfterRenderOptions, 'phase'>,
274+
options?: AfterRenderOptions,
275275
): AfterRenderRef;
276276
/**
277277
* Register effects that, when triggered, are invoked when the application finishes rendering,
@@ -340,7 +340,7 @@ export function afterRenderEffect<E = never, W = never, M = never>(
340340
mixedReadWrite?: (...args: [...ɵFirstAvailableSignal<[W, E]>, EffectCleanupRegisterFn]) => M;
341341
read?: (...args: [...ɵFirstAvailableSignal<[M, W, E]>, EffectCleanupRegisterFn]) => void;
342342
},
343-
options?: Omit<AfterRenderOptions, 'phase'>,
343+
options?: AfterRenderOptions,
344344
): AfterRenderRef;
345345

346346
/**
@@ -357,7 +357,7 @@ export function afterRenderEffect<E = never, W = never, M = never>(
357357
) => M;
358358
read?: (...args: [...ɵFirstAvailableSignal<[M, W, E]>, EffectCleanupRegisterFn]) => void;
359359
},
360-
options?: Omit<AfterRenderOptions, 'phase'>,
360+
options?: AfterRenderOptions,
361361
): AfterRenderRef {
362362
ngDevMode &&
363363
assertNotInReactiveContext(

0 commit comments

Comments
 (0)
0