open external project & reload file without content & tss env vars #236
Conversation
| GetEditsForRefactor("getEditsForRefactor", "2.4.0"); | ||
| GetEditsForRefactor("getEditsForRefactor", "2.4.0"), | ||
|
|
||
| OpenExternalProject("openExternalProject"); |
There was a problem hiding this comment.
Do you know since which version of TypeScript this command is available?
There was a problem hiding this comment.
Sorry, didn't find it yesterday. It seems old because protocol.d.ts includes it since the first commit
https://github.com/Microsoft/TypeScript/commits/master/lib/protocol.d.ts
But the history starts at 2016/10 so it's hard to tell
|
@lgrignon could you add a description what this PR provides please? It seems that you provide 2 features (logs and openExternalProject) But I don't understand openExternalProject how it is consumed? Please add description. Thanks! |
|
Where do you want the description? Anyway I will try to explain my use case a little bit. I intend to use your project as a Java Client API to tsserver without all the Eclipse part. For that matter I will need to add a Maven dependency to your core and it seems that you didn't deploy your core as a Maven artifact, am I right? I wanted to discuss this with you, it seems now is the good time for it :) So basically I will compile some TS files without having necessarily a project directory, or a tssconfig file, and I need to maintain by myself the sources list. That is exactly what external projects allow to do (https://github.com/Microsoft/TypeScript/wiki/Standalone-Server-(tsserver)#external-project) For the log part, it allows the developer to change the tsserver logger's verbosity or output file. I don't think there is much to explain here :) Please tell me if it is ok for you and what are your thoughts about Maven deployment. Thank you for your time. P.S. I need your API for the following open source project: |
|
Ok thanks @lgrignon for your clarification. For the maven feature, please create an issue for that, but I'm afraid that I will have no time to do that. Any help are welcome! |
|
Thanks, I may file a PR later about this. |
Thanks, I'm very busy today with CodeMining support for Eclipse Photon. |
No description provided.