8000 Remove explicit Unit return when using runTest by veyndan · Pull Request #554 · androidx/androidx · GitHub
[go: up one dir, main page]
Skip to content

Remove explicit Unit return when using runTest #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove explicit Unit return when using runTest #554

wants to merge 1 commit into from

Conversation

veyndan
Copy link
Contributor
@veyndan veyndan commented Jun 1, 2023

kotlinx.coroutines.test.runTest returns a kotlinx.coroutines.test.TestResult. Per its documentation, JVM and native just type alias to Unit, but when targeting JS it returns a Promise. This explicit return type of Unit is therefore incorrect when targeting JS.

Test: ./gradlew test connectedCheck
Bug: 270612487

@copybara-service copybara-service bot closed this in e15fde8 Jun 1, 2023
@veyndan veyndan deleted the 270612487/runTest-return branch June 1, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlam dlam dlam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@veyndan @dlam
0