Use atomicfu in paging-common #522
Conversation
There was a problem hiding this comment.
The atomicfu library seems to be in Beta. @ianhanniballake Does this conflict with our general policy to use stable libraries?
|
We can't use atomicfu in androidx just yet. We've had discussions for this before with compose and datastore. We have a very light dependency on it in nativeMain but it's not stable enough for jvm since we want to bring that stable in a reasonable timeframe. |
|
Makes sense. I decided to use atomicfu here purely because I saw it was already in your Multiplatform Paging currently doesn't depend on atomicfu, but instead depends on Stately Concurrency. If you look at the source code, on the JVM, it just directly typealiases to Would you be okay with switching over to Stately Concurrency for this PR instead (which is stable)? |
|
FYI I've already proposed the usage of Stately in #518 |
|
Thanks again for your patience on this PR. Im a bit swamped right now but I'll get to this PR as soon as I can. I need to explore other options / write our own locks(?) as we also want to avoid using Stately for this as well. |
|
Hi @veyndan just wanted to update you -- we want to hold off on adding new dependencies until we cut Paging 3.2, so this PR will be part of Paging 3.3. This should happen within the month. |
|
Ended up using stately for Atomics in #577, closing this one as duplicate. |
Test: ./gradlew test connectedCheck
Bug: 270612487