This repository was archived by the owner on Feb 26, 2023. It is now read-only.
739 logs #794
Merged
739 logs #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…().printMessage(...)
Contributor
Author
|
It would be nice to have someone testing this PR with Gradle, Ant and/or Netbeans :) |
Conflicts: AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/AndroidAnnotationProcessor.java AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/generation/ApiCodeGenerator.java AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/generation/SourceCodewriter.java AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/helper/AnnotationHelper.java AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/process/ModelProcessor.java AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/process/ModelValidator.java
Contributor
Author
|
I think it should work now :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #739
In the end, I didn't use slf4j and an implementation and rewrite a simple logger by myself. Because of this, the user doesn't need to change his factory path to keep project working.
Also, there are two new annotation processing options : logLevel and logFile (which can contains the placeholder
{outputFolder}).The default level is DEBUG, and if no logfile was specified AA will try to resolve the log path by looking if these folders exists (in this order) :
Note : This PR is not finished yet. I still have to add some logs in some important points. But you can start reviewing it.