8000 Remove try/catch block on @Background/@UIThread methods by tbruyelle · Pull Request #682 · androidannotations/androidannotations · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Remove try/catch block on @Background/@UIThread methods #682

Merged
DayS merged 2 commits into from
Jul 28, 2013
Merged

Remove try/catch block on @Background/@UIThread methods #682

DayS merged 2 commits into from
Jul 28, 2013

Conversation

@tbruyelle
Copy link
Contributor
@tbruyelle tbruyelle commented Jul 27, 2013

Related to issue #646 and add fix for PR #677

Because the exception is now propagated, there is no need of catching
it.

Generated code :

    @Override
    public void backgroundThrowException() {
        BackgroundExecutor.execute(new BackgroundExecutor.Task("", 0, "") {


            @Override
            public void execute() {
                ThreadActivity_.super.backgroundThrowException();
            }

        }
        );
    }

Notes

  • The surroundWithTryCatch method is now unused, don't know if I have to remove it or not.

@tbruyelle
Remove try/catch block on @Backgournd/@UIThread methods
4cb345a 
Because the exception is now propagated, there is no need of catching
it.
@DayS
Copy link
Contributor
DayS commented Jul 28, 2013

As catching an exception is not in the AA philosophy, I think you should remove it

@tbruyelle
Copy link
Contributor Author
tbruyelle commented Jul 28, 2013

done 4a6a77b

DayS added a commit that referenced this pull request Jul 28, 2013
@DayS
Merge pull request #682 from tbruyelle/646_PropagateThreadExceptions
0fb5ca3 
Remove try/catch block on @Background/@UIThread methods
@DayS DayS merged commit 0fb5ca3 into androidannotations:develop Jul 28, 2013
@DayS
Copy link
Contributor
DayS commented Jul 28, 2013

Great 👍

@marmor7 marmor7 mentioned this pull request Aug 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tbruyelle @DayS
0