This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Integration with HoloEverywhere #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
I thought you were Michael Greifeneder, not Eric Kok :)
Contributor
|
Appart from the two tiny things, it seems good! You are right with the system service thing. I'm not sure we should play with that, because it may still make sense to inject the original LayoutInflater in some parts of your code. @mathieuboniface @DayS Any thoughts ? |
Contributor
|
Ping @mikegr : are you willing to do these two tiny changes, or should I implement them anyway and then merge ? |
Contributor
Author
|
Sorry for not answering directly after your comments. Can you adjust the code to your wishes? I'm not very familiar with pull requests. Thanks. |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the problem with @optionsmenu and @OptionItem with org.holoeverywhere.app.Fragments.
Futhermore it create onCreateView() methods with LayoutInflater from Holo Everywhere.
The missing part is the annoation @SystemService for LayoutInflater. Not sure about that.