This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Deprecate @HttpsClient #1719
Merged
Deprecate @HttpsClient #1719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4364379 to
2846fd2
Compare
|
|
||
| public void isApacheHttpClientClassPresent(Element element, ElementValidation validation) { | ||
| if (!isClassPresent(CanonicalNameConstants.DEFAULT_HTTP_CLIENT)) { | ||
| validation.addError(element, "The Apache HTTP library is not found on the classpath!"); |
Member
There was a problem hiding this comment.
have you tested this with a gradle project targeting sdk 23+?
Member
|
looks good. |
2846fd2 to
2fcfd54
Compare
2fcfd54 to
5d6baeb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1640.