This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Fix missing varparam in super calls #1705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits fixes a regression introduced in 240c51e. We use the dedicated JMethod#varParam() API to add the variable length parameter, however we only added normal parameters to the super call. Now we also add the dedicated varparam to the super call as well.
This fixes a regression introduced in 240c51e. We use the dedicated JMethod#varParam() API to add the varparam to the overriden method signature, however the `final` modifier was left out. Now we add the `final` modifier to variable length parameters as well.
WonderCsabo
added a commit
that referenced
this pull request
Feb 25, 2016
Fix missing varparam in super calls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1702.