8000 1657 ignore otto annotions for not enhanced classes by dodgex · Pull Request #1658 · androidannotations/androidannotations · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

1657 ignore otto annotions for not enhanced classes #1658

Merged
WonderCsabo merged 2 commits into from
Dec 17, 2015
Merged

1657 ignore otto annotions for not enhanced classes #1658

WonderCsabo merged 2 commits into from
Dec 17, 2015

Conversation

@dodgex
Copy link
Member
@dodgex dodgex commented Dec 17, 2015

see #1657

WonderCsabo
WonderCsabo reviewed Dec 17, 2015
View reviewed changes
...tations-otto/otto/src/main/java/org/androidannotations/otto/handler/AbstractOttoHandler.java
Copy link
Member
@WonderCsabo WonderCsabo Dec 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the next enclosingElementHasEnhancedComponentAnnotation() call?

Copy link
Member Author
@dodgex dodgex Dec 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, i have not touched it as i was not sure why exaclty it was there...

Copy link
Member Author
@dodgex dodgex Dec 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but i think, we can remove it.. double checking should not be necessary

Copy link
Member
@WonderCsabo WonderCsabo Dec 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, i am talking about this. https://github.com/dodgex/androidannotations/blob/1657_ignore_otto_annotions_for_not_enhanced_classes/AndroidAnnotations/androidannotations-otto/otto/src/main/java/org/androidannotations/otto/handler/AbstractOttoHandler.java#L48

Copy link
Member Author
@dodgex dodgex Dec 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a empty line? :D maybe because i already removed the check you were talking about? :)

Copy link
Member
@WonderCsabo WonderCsabo Dec 17, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dodgex
Copy link
Member Author
dodgex commented Dec 17, 2015

updated

WonderCsabo added a commit that referenced this pull request Dec 17, 2015
@WonderCsabo
Merge pull request #1658 from dodgex/1657_ignore_otto_annotions_for_n…
fd1ce76 
…ot_enhanced_classes

Ignore otto annotions for non-enhanced classes
@WonderCsabo WonderCsabo merged commit fd1ce76 into androidannotations:develop Dec 17, 2015
@WonderCsabo WonderCsabo added this to the 4.0 milestone Dec 17, 2015
@WonderCsabo
Copy link
Member
WonderCsabo commented Dec 17, 2015

Thanks very much!

@dodgex dodgex deleted the 1657_ignore_otto_annotions_for_not_enhanced_classes branch December 17, 2015 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dodgex @WonderCsabo
0