8000 fix generated code for emtpy value of @DefaultStringSet by dodgex · Pull Request #1624 · androidannotations/androidannotations · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

fix generated code for emtpy value of @DefaultStringSet #1624

Merged
WonderCsabo merged 2 commits into from
Nov 14, 2015
Merged

fix generated code for emtpy value of @DefaultStringSet #1624

WonderCsabo merged 2 commits into from
Nov 14, 2015

Conversation

@dodgex
Copy link
Member
@dodgex dodgex commented Nov 14, 2015

@dodgex
Copy link
Member Author
dodgex commented Nov 14, 2015

@WonderCsabo maybe extract the keyRes param into a separate annotation? to allow providing a resource for the key without requiring a default value?

@dodgex dodgex mentioned this pull request Nov 14, 2015
Merged
WonderCsabo
WonderCsabo reviewed Nov 14, 2015
View reviewed changes
...api/src/main/java/org/androidannotations/annotations/sharedpreferences/DefaultStringSet.java Outdated
Copy link
Member
@WonderCsabo WonderCsabo Nov 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a String[]

Copy link
Member Author
@dodgex dodgex Nov 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, i copied this from @DefaultInt and didnt recognized the n.

WonderCsabo added a commit that referenced this pull request Nov 14, 2015
@WonderCsabo
Merge pull request #1624 from dodgex/fix_1555_for_emtpy_values
388381d 
Fix generated code for emtpy value of @DefaultStringSet
@WonderCsabo WonderCsabo merged commit 388381d into androidannotations:develop Nov 14, 2015
@WonderCsabo
Copy link
Member
WonderCsabo commented Nov 14, 2015

Thanks for this!

@WonderCsabo WonderCsabo added this to the 4.0 milestone Nov 14, 2015
@dodgex dodgex deleted the fix_1555_for_emtpy_values branch November 15, 2015 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dodgex @WonderCsabo
0