8000 fixes #1604 by ened · Pull Request #1619 · androidannotations/androidannotations · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Conversation

@ened
Copy link
Contributor
@ened ened commented Nov 9, 2015

Use ContextCompat for color & ColorStateList resources.

@WonderCsabo
Copy link
Member

Great, thanks! Can you create a superclass and move all common methods up to it from DrawableResHandler, ColorRestHandler and ColorStateListResHandler?

@ened
Copy link
Contributor Author
ened commented Nov 9, 2015

Yes how about ContextCompatAwareResHandler ?

@WonderCsabo
Copy link
Member

Sounds good!

@WonderCsabo
Copy link
Member

@ened is this ready to be reviewed?

@ened
Copy link
Contributor Author
ened commented Nov 10, 2015

@WonderCsabo yes please.

WonderCsabo added a commit that referenced this pull request Nov 11, 2015
Use proper method to resolve Color and ColorStateList
@WonderCsabo WonderCsabo merged commit d01274d into androidannotations:develop Nov 11, 2015
@WonderCsabo WonderCsabo added this to the 4.0 milestone Nov 11, 2015
@WonderCsabo
Copy link
Member

Great work! Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0