8000 copy @SharedPref javadoc by dodgex · Pull Request #1553 · androidannotations/androidannotations · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

copy @SharedPref javadoc #1553

Merged
WonderCsabo merged 3 commits into from
Sep 18, 2015
Merged

copy @SharedPref javadoc #1553

WonderCsabo merged 3 commits into from
Sep 18, 2015

Conversation

@dodgex
Copy link
Member
@dodgex dodgex commented Sep 17, 2015

see #1551

WonderCsabo
WonderCsabo reviewed Sep 17, 2015
View reviewed changes
.../androidannotations/src/test/java/org/androidannotations/generation/GenerateJavaDocTest.java Outdated
Copy link
Member
@WonderCsabo WonderCsabo Sep 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be more correct to use assertGeneratedClassContains, since we have to check that both the normal and the editor method has the javadoc.

Copy link
Member Author
@dodgex dodgex Sep 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hope that is what you mean

@dodgex dodgex mentioned this pull request Sep 17, 2015
Merged
WonderCsabo added a commit that referenced this pull request Sep 18, 2015
@WonderCsabo
Merge pull request #1553 from dodgex/1551_copy_sharedpref_javadoc
4029d57 
Copy @SharedPref javadoc
@WonderCsabo WonderCsabo merged commit 4029d57 into androidannotations:develop Sep 18, 2015
@WonderCsabo WonderCsabo added this to the 4.0 milestone Sep 18, 2015
@WonderCsabo
Copy link
Member
WonderCsabo commented Sep 18, 2015

Thanks!

@dodgex dodgex deleted the 1551_copy_sharedpref_javadoc branch September 18, 2015 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dodgex @WonderCsabo
0