8000 WIP Plugin system by yDelouis · Pull Request #1480 · androidannotations/androidannotations · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

WIP Plugin system #1480

Merged
WonderCsabo merged 72 commits into from
Sep 10, 2015
Merged

WIP Plugin system #1480

WonderCsabo merged 72 commits into from
Sep 10, 2015

Conversation

@yDelouis
Copy link
Con 8000 tributor
@yDelouis yDelouis commented Jun 24, 2015

This PR is not ready at all and is created only to show the work in progress so that people can comment.

@yDelouis yDelouis force-pushed the 957_plugins branch 3 times, most recently from 70981a1 to e528406 Compare June 24, 2015 21:23
@WonderCsabo WonderCsabo mentioned this pull request Jun 26, 2015
Closed
@yDelouis
Copy link
Contributor Author
yDelouis commented Jul 2, 2015

What would be the folder and maven structure ? I think you proposal will be strange for plugins because we will have : (in [], it is the maven module name)

- AndroidAnnotations [androidannotations-parent]
  | - core [??]
    | - androidannotations [androidannotations]
    | - androidannotations-api [androidannotations-api]
    | - androidannotations-test [androidannotations-test]
  | - ormlite [??]
    | - ormlite [ormlite]
    | - ormlite-api [ormlite-api]
    | - ormlite-test [ormlite-test]

@WonderCsabo
Copy link
Member
WonderCsabo commented Jul 2, 2015

What about this?

- AndroidAnnotations [androidannotations-parent]
  | - androidannotations-core [androidannotations-core]
    | - androidannotations [androidannotations]
    | - androidannotations-api [androidannotations-api]
    | - androidannotations-test [androidannotations-test]
  | - androidannotations-ormlite [androidannotations-ormlite]
    | - ormlite [ormlite]
    | - ormlite-api [ormlite-api]
    | - ormlite-test [ormlite-test]

@yDelouis
Copy link
Contributor Author
yDelouis commented Jul 2, 2015

Your proposition makes sense.
The only thing I don't like is that the names are very long and it won't fit on one line in my terminal.

yDelouis and others added 19 commits July 10, 2015 23:04
@yDelouis @WonderCsabo
Ease validation
db7270e 
This commit remove the need to invalidate the IsValid instance and to
print the error. All is done with on method.
@yDelouis @WonderCsabo
Remove code relative to api copy
a4d025c 
We don't copy api classes anymore since it can break projects with
libraries using AA.
@yDelouis @WonderCsabo
New folder structure
e140ac1
@yDelouis @WonderCsabo
Create plugin OrmLite
7bd9fa1
@yDelouis @WonderCsabo
Rename package org.androidannotations.test15 to org.androidannotation…
9fc1038 
…s.test
@WonderCsabo
Relax Maven enforcement to 3.0.5
d5c42e7
@WonderCsabo
Fix Ormlite test project POM
a06e957
@WonderCsabo
Moved OrmLite to better structure
f3d570a
@WonderCsabo
Change folder structure
dc41d31
@WonderCsabo
Remove bundle and fat-jar modules
27e6a97 
We decided to no longer generate and release bundles, since most developers now use much more convenient dependency management.
@WonderCsabo
Remove unnecessary dependencies and plugins
01ea8b9
@WonderCsabo
Delete old tests related to 7440 api class generation
62e5578 
We no longer generate API classes, because all API classes are statically compiled into the API jar. So these tests are obsolete.
@WonderCsabo
Fix some problems with ValidatorHelper
f13abd5 
Also remove no longer used methods.
@WonderCsabo
Clean up androidannotations-test AndroidManifest.xml
9266cc8 
Some test Activities were removed.
@WonderCsabo
Use Java 7 diamond where missing
af00856
@WonderCsabo
Create Otto plugin
89ef719
@WonderCsabo
Refactor Otto handlers
08c7be5
@WonderCsabo
Only depend on Android 2.3.1 in processor modules
855f28c
@WonderCsabo
Fix generated source header format
4613d98
< 8000 /div>
@ened
Copy link
Contributor
ened commented Aug 18, 2015

Do you guys have a mvn snapshot repo (maybe via github) for this PR, so interested folks could help testing?

@dodgex
Copy link
Member
dodgex commented Aug 18, 2015

as far as i know no, but you can checkout https://github.com/yDelouis/androidannotations/tree/957_plugins and run mvn install to get the snapshot into your local mvn repo

@WonderCsabo
Copy link
Member
WonderCsabo commented Sep 1, 2015

@dodgex is right, we do not have a repo, but interested folks can really simple build the lib itself. I really hope this will be merged into develop soon, after that you can try in the conventional OSS snapshot repo.

WonderCsabo added a commit that referenced this pull request Sep 10, 2015
@WonderCsabo
Merge pull request #1480 from yDelouis/957_plugins
c4567fe 
Plugin system
@WonderCsabo WonderCsabo merged commit c4567fe into androidannotations:develop Sep 10, 2015
@dodgex
Copy link
Member
dodgex commented Sep 11, 2015

Nice! Finally merged. :D

@dodgex
Copy link
Member
dodgex commented Sep 11, 2015

Let the Plugin Hell begin 😄

@WonderCsabo WonderCsabo added this to the 4.0 milestone Sep 12, 2015
@yDelouis yDelouis deleted the 957_plugins branch September 19, 2015 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yDelouis @WonderCsabo @ened @dodgex
0