8000 Fix PreferenceActivity RuntimeException with @PreferenceScreen by WonderCsabo · Pull Request #1398 · androidannotations/androidannotations · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Fix PreferenceActivity RuntimeException with @PreferenceScreen #1398

Closed
WonderCsabo wants to merge 3 commits into from
Closed

Fix PreferenceActivity RuntimeException with @PreferenceScreen #1398

WonderCsabo wants to merge 3 commits into from

Conversation

@WonderCsabo
Copy link
Member
@WonderCsabo WonderCsabo commented May 5, 2015

Fixes #1392.

DayS and others added 2 commits November 9, 2014 16:43
@DayS
Merge tag 'androidannotations-3.2'
b01a7c2
@WonderCsabo
Merge tag 'androidannotations-3.3'
dc8302b 
[maven-release-plugin] copy for tag androidannotations-3.3
@dodgex
Copy link
Member
dodgex commented May 6, 2015

assuming that you did a small test with a "real" app i'd say lgtm! ;)

@WonderCsabo
Copy link
Member Author
WonderCsabo commented May 6, 2015

Yeah, i did it with the example app.

@yDelouis
Copy link
Contributor
yDelouis commented May 8, 2015

I didn't test this myself but I trust you and the code seems OK.

@WonderCsabo
Fix PreferenceActivity RuntimeException with @PreferenceScreen
a52c6a5 
The problem was that we called the addPreferencesFromResource method
before calling super.onCreate().
@WonderCsabo WonderCsabo force-pushed the 1393_preferenceScreenRuntimExceptionWithPreferenceActivity branch from 6e239ab to a52c6a5 Compare May 9, 2015 08:47
WonderCsabo added a commit that referenced this pull request May 9, 2015
@WonderCsabo
Merge pull request #1398 into hotfix-3.3.1
571508b 
Fix PreferenceActivity RuntimeException with @PreferenceScreen
@WonderCsabo WonderCsabo closed this May 9, 2015
@WonderCsabo WonderCsabo deleted the 1393_preferenceScreenRuntimExceptionWithPreferenceActivity branch May 9, 2015 10:52
@WonderCsabo WonderCsabo restored the 1393_preferenceScreenRuntimExceptionWithPreferenceActivity branch May 9, 2015 10:52
@WonderCsabo WonderCsabo deleted the 1393_preferenceScreenRuntimExceptionWithPreferenceActivity branch May 9, 2015 10:52
@WonderCsabo WonderCsabo added this to the 3.3.1 milestone May 9, 2015
@WonderCsabo
Copy link
Member Author
WonderCsabo commented May 9, 2015

Rebased and merged as of 571508b.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

3.3.1

Development

Successfully merging this pull request may close these issues.

RuntimeException with @PreferenceScreen

4 participants

@WonderCsabo @dodgex @yDelouis @DayS
0