8000 Fix for @ViewById generic issues by WonderCsabo · Pull Request #1353 · androidannotations/androidannotations · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Fix for @ViewById generic issues #1353

Merged
yDelouis merged 3 commits into from
Apr 6, 2015
Merged

Fix for @ViewById generic issues #1353

yDelouis merged 3 commits into from
Apr 6, 2015

Conversation

@WonderCsabo
Copy link
Member
8000 @WonderCsabo WonderCsabo commented Mar 24, 2015

Fixes #1351.

@WonderCsabo WonderCsabo changed the title 1351 view by id generics Fix for @ViewById generic issues Mar 24, 2015
@WonderCsabo WonderCsabo force-pushed the 1351_viewByIdGenerics branch from 0dc46ac to 88f3511 Compare March 25, 2015 00:04
WonderCsabo
WonderCsabo reviewed Mar 25, 2015
View reviewed changes
...tions/androidannotations/src/main/java/org/androidannotations/helper/APTCodeModelHelper.java
Copy link
Member Author
@WonderCsabo WonderCsabo Mar 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this because now we do not need the TypeElement passed to this method, which is not always available. I know this is ugly and an anti-pattern, but the other way is using 30 lines of reflective code to access the needed values from CodeModel. 😟

Copy link
Contributor
@yDelouis yDelouis Apr 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with that.

@WonderCsabo WonderCsabo force-pushed the 1351_viewByIdGenerics branch from 88f3511 to df6e8f0 Compare April 5, 2015 22:01
@WonderCsabo
Copy link
Member Author
WonderCsabo commented Apr 5, 2015

PR updated

yDelouis added a commit that referenced this pull request Apr 6, 2015
Merge pull request #1353 from WonderCsabo/1351_viewByIdGenerics
a895949 
Fix for @ViewById generic issues
@yDelouis yDelouis merged commit a895949 into androidannotations:develop Apr 6, 2015
@yDelouis yDelouis added this to the 3.3 milestone Apr 6, 2015
@WonderCsabo WonderCsabo deleted the 1351_viewByIdGenerics branch April 6, 2015 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

ViewById with generics - creates syntax errors in generated class

2 participants

@WonderCsabo @yDelouis
0