This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Fixed classpath issues with RoboGuice #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some classes of RoboGuice are referencing the android.support package. This is problematic, since it is not always in the classpath. In that case, generated code cannot be compiled if support classes are indirectly referenced, also validation can go wrong. This commit fixes that issue by removing all indirect reference to the support package.
Contributor
There was a problem hiding this comment.
Why don't you catch any RuntimeException in a single catch ?
It would enable us to remove the method propagateRuntimeException.
Member
Author
There was a problem hiding this comment.
I do not like catching any exceptions, and it is a very bad design, since that means just consuming all RuntimeExceptions, for example NPE, too. The current code is ugly, but would be much nicer if we would use Java 7, because we could just catchReflectiveOperationException.
Member
There was a problem hiding this comment.
Is Java 6 Supported or are we building for 7? Then you could go with Multi catch.
Member
Author
There was a problem hiding this comment.
We use Java 6, see the newest issue.
Member
Author
|
@yDelouis can we merge this or do you have further comments? |
WonderCsabo
added a commit
that referenced
this pull request
Oct 12, 2014
…roblem Fixed classpath issues with RoboGuice
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1116.