This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Building Gradle sample in Travis #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.travis.yml
Outdated
Contributor
There was a problem hiding this comment.
Why do you skip javadoc ?
Member
Author
There was a problem hiding this comment.
Travis builds are skipping JavaDoc by default (if the language if set to java). We should do the same here. JavaDoc is slowing the build and is polluting the logs. Or do you think it is useful?
Contributor
There was a problem hiding this comment.
Javadoc can prevent builds from succeeding so I think it should be tested.
Member
Author
There was a problem hiding this comment.
Only the javadoc goal broke i think, but you are right, since we ask our contributors to build with mvn install, Travis should do the same.
The previous version tried to resolved optional dependencies which are no longer in Maven Central (namely android-rome-feed-reader). The new version does not do this, so we can build without the presence optional dependencies.
72f6e75 to
6cef8cd
Compare
WonderCsabo
added a commit
that referenced
this pull request
Aug 30, 2014
Building Gradle sample in Travis
Contributor
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be sure that changes do not brake our Gradle configuration, so we are building both maven and Gradle examples in Travis.