New @Receiver attribute: scheme #1096 #1101
Conversation
|
Thanks! @yDelouis please review the code, as the original author of |
|
i'm just working on the tests. same as in @ReceiverAction, there are classes with this annotation in functional-test-1-5 but no actual tests in functional-test-1-5-tests |
|
interesting. not sure if it is a robolectric problem, but if i have |
|
Can you post your tests? If you are still not certain about rebasing, just simply create a branch without a pull request. |
|
https://github.com/dodgex/androidannotations/tree/ReceiverDataSchemesTest |
|
I tested and i think you are right. Can you create a simple test-case project (for example based on deckard) so we can ask about this issue in the |
|
i have openend an issue on robolectric with sample project. robolectric/robolectric#1244 |
|
Thank you! I hope we get some response from the robolectric team soon. |
|
@WonderCsabo okay. sorry. |
|
It seems we won't have a response from the robolectric team soon. Please add your tests to this PR, and comment |
|
done with a comment why the test is commented out and a link to the robolectric issue |
|
i also proposed a PR(robolectric/robolectric#1250) to robolectric fixing the tests. so a response is (hopefully) more likely |
|
Nice and easy fix! But i think you also have to add some tests here. However, your change will not be available soon in a stable robolectric release, so we should leave the test commented for now. |
|
@WonderCsabo you are right. ;) Jake asked me to add tests. have done that now. :) |
|
The PR is merged. So as soon as 2.4 gets released we can enable our test. 👍 |
|
Congrats, and thanks! It seems they are only react to PRs... I did not get any responses in this issue (also related to AA), despite i also posted about in the robolectric mailing list. |
AA saved me so much time and made my code cleaner. I want to give something back. not only by implementing stuff i need, but also by implementing stuff that others could need. like this one. I'm proud to be able to contribute! :) |
|
@yDelouis do you plan to review this? |
|
rebased on current develop. |
|
Good work ! Thanks. |
|
@dodgex Please add documentation. Before that, reset your wiki to our HEAD, because i rebased your commits. Also please be careful about line endings. Thanks. |
|
Also the JavaDoc is missing for this feature. Please add that in a new PR. |
|
WTH. I'm 100% sure there was javadoc. might be lost during the rebase as the import in the EReceiver PR. I'll try to fix this asap. same for wiki. |
|
already posted link to wiki update in PR but to have it in the issue with "WikiUpdate" label i'll post it here too https://github.com/dodgex/androidannotations/wiki/Receiving-intents |
|
Wiki updated, thanks! |
this implements: #1096