This repository has been archived by the owner on Jun 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 359
refactoring and reducing warnings and alerts #588
Draft
ziegenberg
wants to merge
28
commits into
andOTP:master
Choose a base branch
from
ziegenberg:simple_refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc0503
approved these changes
Nov 4, 2020
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
typo in string reference Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
A static inner class does not keep an implicit reference to its enclosing instance. This prevents a common cause of memory leaks and uses less memory per instance of the class. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
…nio.charset.StandardCharsets.UTF_8 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
simple_refactor
branch
from
January 5, 2021 18:01
e6fba85
to
9d2d88d
Compare
ziegenberg
changed the title
(not so) simple rework
refactoring and reducing warnings and alerts
Jan 5, 2021
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at> remove unnecessary boxing and unboxing
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
… and use Java 7 Automatic Resource Management Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
- BroadcastReceivedCallback() - Callable() - EncryptionChangeCallback() - OnActionSelectedListener() - OnClickListener() - OnItemClickListener() - OnLongClickListener() - OnMenuItemClickListener() - OnPreferenceChangeListener() - OnPreferenceClickListener() - PasswordEnteredCallback() - Runnable()
- 'UnsupportedEncodingException' - 'InvalidAlgorithmParameterException' - 'IOException' Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
…des IDE with Gradle API/DSL documentation
ziegenberg
force-pushed
the
simple_refactor
branch
from
January 6, 2021 00:59
9d2d88d
to
6aa746a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce warnings and alerts from running code inspections.