fix(apk): find secdb entries for origin packages #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f53d61
to
8ab6e16
Compare
8ab6e16
to
3d46a82
Compare
|
@wagoodman Just hit this bug again (which produces false positives) — maybe we could try to land this? |
3d46a82
to
595c2ff
Compare
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
595c2ff
to
9c264de
Compare
wagoodman
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in Grype's APK matching logic (affecting Alpine and Wolfi) where if there was an NVD match to a package, Grype wasn't doing the resolution-to-origin-package to find relevant data in the secdb for the match. This created a case where Grype would show a distro package as vulnerable even though the distro had marked the package as fixed or a false positive already.
This PR adds the missing check to the matcher and adds a unit test to cover this case.